Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2545663005: Remove MediaQuerySet:createOffMainThread. (Closed)

Created:
4 years ago by rune
Modified:
4 years ago
Reviewers:
Timothy Loh, Yoav Weiss
CC:
chromium-reviews, kenneth.christiansen, blink-reviews-css, blink-reviews-html_chromium.org, loading-reviews+parser_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, kinuko+watch, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove MediaQuerySet:createOffMainThread. The implementation is identical to MediaQuerySet::create. Removed old cruft from the unit test from when we had two media query parsing implementation. R=yoav@yoav.ws,timloh@chromium.org Committed: https://crrev.com/47f8406eb6b473ba158e591bb916ab4a59d60be5 Cr-Commit-Position: refs/heads/master@{#435920}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -155 lines) Patch
M third_party/WebKit/Source/core/css/MediaList.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/MediaList.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQuerySetTest.cpp View 3 chunks +131 lines, -145 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
rune
ptal
4 years ago (2016-12-02 10:35:58 UTC) #2
Yoav Weiss
On 2016/12/02 10:35:58, rune wrote: > ptal LGTM
4 years ago (2016-12-02 11:39:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2545663005/1
4 years ago (2016-12-02 12:13:49 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 12:17:48 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-02 12:20:09 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/47f8406eb6b473ba158e591bb916ab4a59d60be5
Cr-Commit-Position: refs/heads/master@{#435920}

Powered by Google App Engine
This is Rietveld 408576698