Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2545663004: [ios] Fixed memory management in ExecuteScriptOnInterstitial. (Closed)

Created:
4 years ago by Eugene But (OOO till 7-30)
Modified:
4 years ago
Reviewers:
Jackie Quinn
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Fixed memory management in ExecuteScriptOnInterstitial. Autoreleasing inside the block made object released and caused a crash on iOS9. BUG=531721 Committed: https://crrev.com/5dd3785b5c294e45f766064723f6edd900900fdc Cr-Commit-Position: refs/heads/master@{#435778}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ios/web/public/test/earl_grey/js_test_util.mm View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Eugene But (OOO till 7-30)
4 years ago (2016-12-01 23:38:17 UTC) #2
Jackie Quinn
lgtm
4 years ago (2016-12-01 23:46:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2545663004/1
4 years ago (2016-12-01 23:46:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 23:58:32 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-02 00:00:42 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5dd3785b5c294e45f766064723f6edd900900fdc
Cr-Commit-Position: refs/heads/master@{#435778}

Powered by Google App Engine
This is Rietveld 408576698