Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: chrome/browser/ui/webui/print_preview/printer_backend_proxy_chromeos.cc

Issue 2545663002: Hookup the PpdProvider in the printer setup flow. (Closed)
Patch Set: address dpadpad@ comment Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/print_preview/printer_backend_proxy_chromeos.cc
diff --git a/chrome/browser/ui/webui/print_preview/printer_backend_proxy_chromeos.cc b/chrome/browser/ui/webui/print_preview/printer_backend_proxy_chromeos.cc
index 0cffa21e0c591123901b58e4be5f9689266680b7..aa1676b1e1ffa88848a89d614870f24e8ea90c89 100644
--- a/chrome/browser/ui/webui/print_preview/printer_backend_proxy_chromeos.cc
+++ b/chrome/browser/ui/webui/print_preview/printer_backend_proxy_chromeos.cc
@@ -96,12 +96,6 @@ void OnPrinterAddError(const PrinterSetupCallback& cb) {
PostCallbackError(cb);
}
-bool IsIppEverywhere(const chromeos::Printer& printer) {
- // TODO(skau): Use uri, effective_make and effective_model to determine if
- // we should do an IPP Everywhere configuration.
- return false;
-}
-
std::string GetPPDPath(const chromeos::Printer& printer) {
// TODO(skau): Consult the PPD Provider for the correct file path.
return printer.ppd_reference().user_supplied_ppd_url;
@@ -146,7 +140,7 @@ void ConfigurePrinterAndFetchCapabilities(Profile* profile,
std::unique_ptr<chromeos::Printer> printer = prefs->GetPrinter(printer_name);
// Check if configuration is viable.
- bool ipp_everywhere = IsIppEverywhere(*printer);
+ bool ipp_everywhere = printer->IsIppEverywhere();
std::string ppd_path = GetPPDPath(*printer);
if (!ipp_everywhere && ppd_path.empty()) {
HandlePrinterSetup(std::move(printer), PPD_NOT_FOUND, cb);
« no previous file with comments | « no previous file | chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698