Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2545633002: Tolerate more than one copy of the --mash command line switch (Closed)

Created:
4 years ago by James Cook
Modified:
4 years ago
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tolerate more than one copy of the --mash command line switch It's common to add --mash to the /etc/chrome_dev.conf when working on a Chrome OS device. However, that can lead to two copies of --mash if you run an autotest on the device that also passes --mash. This makes Chrome crash. Ignore duplicate --mash flags. BUG=669705 TEST=Run chrome --mash --mash, doesn't crash. Committed: https://crrev.com/e498622015dd9b7355fc941c1e5837ff104ac9e2 Cr-Commit-Position: refs/heads/master@{#435655}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M chrome/app/mash/mash_runner.cc View 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
James Cook
rockot, please take a look.
4 years ago (2016-12-01 00:24:26 UTC) #3
Ken Rockot(use gerrit already)
lgtm
4 years ago (2016-12-01 18:16:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2545633002/20001
4 years ago (2016-12-01 18:32:00 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-01 18:38:06 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-01 18:42:07 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e498622015dd9b7355fc941c1e5837ff104ac9e2
Cr-Commit-Position: refs/heads/master@{#435655}

Powered by Google App Engine
This is Rietveld 408576698