Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 254563005: sync: Remove unnecessary DCHECKs from about:sync (Closed)

Created:
6 years, 8 months ago by rlarocque
Modified:
6 years, 7 months ago
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

sync: Remove unnecessary DCHECKs from about:sync Removes a DCHECK in SyncBackendHostImpl that would trigger if we tried to register to observe protocol events (ie. open the about:sync page) before initialization was complete. This DCHECK was unnecessary, since there should be no harm in registering an observer before the sync backend is initialized. Allowing early registration makes the protocol logs useful for debugging more kinds of issues. BUG=365806 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266643

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/browser/sync/glue/sync_backend_host_impl.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
rlarocque
Please review.
6 years, 8 months ago (2014-04-24 19:08:25 UTC) #1
tim (not reviewing)
thanks! LGTM
6 years, 8 months ago (2014-04-24 19:22:09 UTC) #2
rlarocque
The CQ bit was checked by rlarocque@chromium.org
6 years, 8 months ago (2014-04-24 19:43:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/254563005/1
6 years, 8 months ago (2014-04-24 21:48:20 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 22:39:53 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 8 months ago (2014-04-24 22:39:53 UTC) #6
rlarocque
The CQ bit was checked by rlarocque@chromium.org
6 years, 8 months ago (2014-04-24 22:46:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/254563005/1
6 years, 8 months ago (2014-04-24 22:47:17 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-25 00:20:26 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-25 00:20:27 UTC) #10
rlarocque
The CQ bit was checked by rlarocque@chromium.org
6 years, 8 months ago (2014-04-25 01:05:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/254563005/1
6 years, 8 months ago (2014-04-25 01:06:49 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-25 03:04:10 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-25 03:04:10 UTC) #14
rlarocque
The CQ bit was checked by rlarocque@chromium.org
6 years, 7 months ago (2014-04-28 17:24:55 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/254563005/1
6 years, 7 months ago (2014-04-28 17:25:54 UTC) #16
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 20:07:20 UTC) #17
Message was sent while issue was closed.
Change committed as 266643

Powered by Google App Engine
This is Rietveld 408576698