Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1287)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 254563002: Add a comment to allowConnectingInsecureWebSocket in Settings.in (Closed)

Created:
6 years, 8 months ago by tyoshino (SeeGerritForStatus)
Modified:
6 years, 8 months ago
Reviewers:
tkent
CC:
blink-reviews
Visibility:
Public.

Description

Add a comment to allowConnectingInsecureWebSocket in Settings.in This was to be included in this change, but I forgot to upload the latest copy. https://codereview.chromium.org/246893014/ This comment was suggested by abarth@ in this comment. https://codereview.chromium.org/246893014/#msg12 BUG=85271 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172468

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/core/frame/Settings.in View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tyoshino (SeeGerritForStatus)
6 years, 8 months ago (2014-04-24 05:49:50 UTC) #1
tkent
lgtm
6 years, 8 months ago (2014-04-24 06:01:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/254563002/1
6 years, 8 months ago (2014-04-24 06:02:08 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 06:46:43 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-24 06:46:44 UTC) #5
tyoshino (SeeGerritForStatus)
The CQ bit was checked by tyoshino@chromium.org
6 years, 8 months ago (2014-04-24 07:21:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/254563002/1
6 years, 8 months ago (2014-04-24 07:22:59 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-24 08:29:43 UTC) #8
Message was sent while issue was closed. 
Change committed as 172468

Powered by Google App Engine
This is Rietveld 408576698