runtime/vm/ast.cc - Issue 25456005: Add type check to const conditional expression evaluation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/ast.cc

Issue 25456005: Add type check to const conditional expression evaluation (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/ast.cc

===================================================================

--- runtime/vm/ast.cc (revision 28166)

+++ runtime/vm/ast.cc (working copy)

@@ -386,6 +386,7 @@

const Instance* ConditionalExprNode::EvalConstExpr() const {

const Instance* cond = this->condition()->EvalConstExpr();

if ((cond != NULL) &&

+ cond->IsBool() &&

(this->true_expr()->EvalConstExpr() != NULL) &&

(this->false_expr()->EvalConstExpr() != NULL)) {

return cond;

« no previous file with comments | « no previous file | runtime/vm/parser.cc » ('j') | no next file with comments »