Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_observer.cc

Issue 2545593003: Additional heuristic user interaction attribution for page load metrics (Closed)
Patch Set: address comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/page_load_metrics_observer.cc
index 24a85531e6240414d781545525024abf102d546b..cb27c0d8c4fffe7938f1780a871c501ff2774daa 100644
--- a/chrome/browser/page_load_metrics/page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/page_load_metrics_observer.cc
@@ -10,11 +10,11 @@ PageLoadExtraInfo::PageLoadExtraInfo(
const base::Optional<base::TimeDelta>& first_background_time,
const base::Optional<base::TimeDelta>& first_foreground_time,
bool started_in_foreground,
- bool user_initiated,
+ UserInitiatedInfo user_initiated_info,
const GURL& committed_url,
const GURL& start_url,
UserAbortType abort_type,
- bool abort_user_initiated,
+ UserInitiatedInfo abort_user_initiated_info,
const base::Optional<base::TimeDelta>& time_to_abort,
int num_cache_requests,
int num_network_requests,
@@ -22,11 +22,11 @@ PageLoadExtraInfo::PageLoadExtraInfo(
: first_background_time(first_background_time),
first_foreground_time(first_foreground_time),
started_in_foreground(started_in_foreground),
- user_initiated(user_initiated),
+ user_initiated_info(user_initiated_info),
committed_url(committed_url),
start_url(start_url),
abort_type(abort_type),
- abort_user_initiated(abort_user_initiated),
+ abort_user_initiated_info(abort_user_initiated_info),
time_to_abort(time_to_abort),
num_cache_requests(num_cache_requests),
num_network_requests(num_network_requests),
« no previous file with comments | « chrome/browser/page_load_metrics/page_load_metrics_observer.h ('k') | chrome/browser/page_load_metrics/page_load_tracker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698