Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1444)

Unified Diff: chrome/browser/page_load_metrics/metrics_web_contents_observer.h

Issue 2545593003: Additional heuristic user interaction attribution for page load metrics (Closed)
Patch Set: address comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/metrics_web_contents_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/metrics_web_contents_observer.h
diff --git a/chrome/browser/page_load_metrics/metrics_web_contents_observer.h b/chrome/browser/page_load_metrics/metrics_web_contents_observer.h
index 5ecd66cc430ccdb20728f6f050ae53c205a64231..02d4a80bb68a00010fb389bc134703434ef1104d 100644
--- a/chrome/browser/page_load_metrics/metrics_web_contents_observer.h
+++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer.h
@@ -96,9 +96,10 @@ class MetricsWebContentsObserver
// Notify all loads, provisional and committed, that we performed an action
// that might abort them.
- void NotifyAbortAllLoads(UserAbortType abort_type, bool user_initiated);
+ void NotifyAbortAllLoads(UserAbortType abort_type,
+ UserInitiatedInfo user_initiated_info);
void NotifyAbortAllLoadsWithTimestamp(UserAbortType abort_type,
- bool user_initiated,
+ UserInitiatedInfo user_initiated_info,
base::TimeTicks timestamp,
bool is_certainly_browser_timestamp);
@@ -111,7 +112,8 @@ class MetricsWebContentsObserver
// loads. This method returns the provisional load that was likely aborted
// by this navigation, to help instantiate the new PageLoadTracker.
std::unique_ptr<PageLoadTracker> NotifyAbortedProvisionalLoadsNewNavigation(
- content::NavigationHandle* new_navigation);
+ content::NavigationHandle* new_navigation,
+ UserInitiatedInfo user_initiated_info);
void OnTimingUpdated(content::RenderFrameHost*,
const PageLoadTiming& timing,
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/metrics_web_contents_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698