Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(905)

Unified Diff: pkg/analysis_server/lib/src/analysis_server.dart

Issue 2545553007: Add support for generating lints when using the new driver (Closed)
Patch Set: fix some tests Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/context_manager.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/analysis_server.dart
diff --git a/pkg/analysis_server/lib/src/analysis_server.dart b/pkg/analysis_server/lib/src/analysis_server.dart
index c16ed6ba98cebcac5e3e576f2d7887ab8a1c1674..ae25102cf65041bec9e0659f06432b36f56b39fd 100644
--- a/pkg/analysis_server/lib/src/analysis_server.dart
+++ b/pkg/analysis_server/lib/src/analysis_server.dart
@@ -907,7 +907,7 @@ class AnalysisServer {
* Return `true` if analysis is complete.
*/
bool isAnalysisComplete() {
- return operationQueue.isEmpty;
+ return operationQueue.isEmpty && !analysisDriverScheduler.isAnalyzing;
}
/**
@@ -1152,10 +1152,14 @@ class AnalysisServer {
}
/**
- * Send status notification to the client. The `operation` is the operation
- * being performed or `null` if analysis is complete.
+ * Send status notification to the client. The state of analysis is given by
+ * the [status] information.
*/
void sendStatusNotificationNew(nd.AnalysisStatus status) {
+ if (_onAnalysisCompleteCompleter != null && !status.isAnalyzing) {
+ _onAnalysisCompleteCompleter.complete();
+ _onAnalysisCompleteCompleter = null;
+ }
// Only send status when subscribed.
if (!serverServices.contains(ServerService.STATUS)) {
return;
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/context_manager.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698