Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1717)

Unified Diff: chrome/browser/media/webrtc/webrtc_internals_perf_browsertest.cc

Issue 2545553003: WebRtcStatsPerfBrowserTest added, a perf test using the new getStats (Closed)
Patch Set: Addressed nits, rebase, default initialize Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/webrtc/webrtc_internals_perf_browsertest.cc
diff --git a/chrome/browser/media/webrtc/webrtc_perf_browsertest.cc b/chrome/browser/media/webrtc/webrtc_internals_perf_browsertest.cc
similarity index 95%
copy from chrome/browser/media/webrtc/webrtc_perf_browsertest.cc
copy to chrome/browser/media/webrtc/webrtc_internals_perf_browsertest.cc
index f08e8ff6a852fb06fa0e171c8b6904cab3c121e5..7b5f6ddac60e3034eab58427d409a099e738b0f2 100644
--- a/chrome/browser/media/webrtc/webrtc_perf_browsertest.cc
+++ b/chrome/browser/media/webrtc/webrtc_internals_perf_browsertest.cc
@@ -42,7 +42,8 @@ std::string MakePerfTestLabel(std::string base, bool opus_dtx) {
// Performance browsertest for WebRTC. This test is manual since it takes long
// to execute and requires the reference files provided by the webrtc.DEPS
// solution (which is only available on WebRTC internal bots).
-class WebRtcPerfBrowserTest : public WebRtcTestBase {
+// Gets its metrics from "chrome://webrtc-internals".
+class WebRtcInternalsPerfBrowserTest : public WebRtcTestBase {
public:
void SetUpInProcessBrowserTestFixture() override {
DetectErrorsInJavaScript(); // Look for errors in our rather complex js.
@@ -223,13 +224,13 @@ class WebRtcPerfBrowserTest : public WebRtcTestBase {
// This is manual for its long execution time.
IN_PROC_BROWSER_TEST_F(
- WebRtcPerfBrowserTest,
+ WebRtcInternalsPerfBrowserTest,
MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsVp8) {
RunsAudioVideoCall60SecsAndLogsInternalMetrics("VP8");
}
IN_PROC_BROWSER_TEST_F(
- WebRtcPerfBrowserTest,
+ WebRtcInternalsPerfBrowserTest,
MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsVp9) {
RunsAudioVideoCall60SecsAndLogsInternalMetrics("VP9");
}
@@ -237,13 +238,14 @@ IN_PROC_BROWSER_TEST_F(
#if BUILDFLAG(RTC_USE_H264)
IN_PROC_BROWSER_TEST_F(
- WebRtcPerfBrowserTest,
+ WebRtcInternalsPerfBrowserTest,
MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsH264) {
// Only run test if run-time feature corresponding to |rtc_use_h264| is on.
if (!base::FeatureList::IsEnabled(content::kWebRtcH264WithOpenH264FFmpeg)) {
LOG(WARNING) << "Run-time feature WebRTC-H264WithOpenH264FFmpeg disabled. "
- "Skipping WebRtcPerfBrowserTest.MANUAL_RunsAudioVideoCall60SecsAndLogs"
- "InternalMetricsH264 (test \"OK\")";
+ "Skipping WebRtcInternalsPerfBrowserTest."
+ "MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsH264 (test "
+ "\"OK\")";
return;
}
RunsAudioVideoCall60SecsAndLogsInternalMetrics("H264");
@@ -252,13 +254,13 @@ IN_PROC_BROWSER_TEST_F(
#endif // BUILDFLAG(RTC_USE_H264)
IN_PROC_BROWSER_TEST_F(
- WebRtcPerfBrowserTest,
+ WebRtcInternalsPerfBrowserTest,
MANUAL_RunsOneWayCall60SecsAndLogsInternalMetricsDefault) {
RunsOneWayCall60SecsAndLogsInternalMetrics("", false);
}
IN_PROC_BROWSER_TEST_F(
- WebRtcPerfBrowserTest,
+ WebRtcInternalsPerfBrowserTest,
MANUAL_RunsOneWayCall60SecsAndLogsInternalMetricsWithOpusDtx) {
RunsOneWayCall60SecsAndLogsInternalMetrics("", true);
}
« no previous file with comments | « chrome/browser/media/webrtc/webrtc_browsertest_base.cc ('k') | chrome/browser/media/webrtc/webrtc_perf_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698