Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2545553002: Make LCMS2 source files utf-8 (Closed)

Created:
4 years ago by scottmg
Modified:
4 years ago
Reviewers:
brucedawson
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Make LCMS2 source files utf-8 R=brucedawson@chromium.org BUG=637203, 454858

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -16 lines) Patch
M third_party/lcms2-2.6/src/cmscgats.c View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/lcms2-2.6/src/cmstypes.c View 4 chunks +8 lines, -6 lines 0 comments Download
M third_party/lcms2-2.6/src/cmsvirt.c View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
scottmg
I had to do some interpretation here, as it wasn't clear what code page these ...
4 years ago (2016-11-30 19:35:33 UTC) #3
scottmg
Hmm, maybe I uploaded this change wrong? Is it not possible to change the copy ...
4 years ago (2016-11-30 19:46:29 UTC) #8
scottmg
On 2016/11/30 19:46:29, scottmg wrote: > Hmm, maybe I uploaded this change wrong? Is it ...
4 years ago (2016-11-30 19:46:42 UTC) #9
scottmg
On 2016/11/30 19:46:42, scottmg wrote: > On 2016/11/30 19:46:29, scottmg wrote: > > Hmm, maybe ...
4 years ago (2016-11-30 20:28:25 UTC) #10
scottmg
4 years ago (2016-11-30 20:32:34 UTC) #11
On 2016/11/30 20:28:25, scottmg wrote:
> On 2016/11/30 19:46:42, scottmg wrote:
> > On 2016/11/30 19:46:29, scottmg wrote:
> > > Hmm, maybe I uploaded this change wrong? Is it not possible to change the
> copy
> > > of pdfium in the chromium tree?
> > 
> > (Or maybe the trybots just don't work?)
> 
> Hmm, I think it might just not like the funny characters either, so this might
> have to be `git cl land`ed.

Oh, I see there's a .patch routine required here. OK, pulled the pdfium repo,
and made a hopefully happier change here:
https://codereview.chromium.org/2545593002. Closing this one.

Powered by Google App Engine
This is Rietveld 408576698