Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 2545543003: Split up quic_frames.{h,cc} into files for each frame type. (Closed)

Created:
4 years ago by Victor Vasiliev
Modified:
4 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split up quic_frames.{h,cc} into files for each frame type. Merge internal change: 139607554 R=rch@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1196 lines, -1137 lines) Patch
M net/net.gypi View 4 chunks +25 lines, -3 lines 0 comments Download
A net/quic/core/frames/quic_ack_frame.h View 1 chunk +132 lines, -0 lines 0 comments Download
A net/quic/core/frames/quic_ack_frame.cc View 1 chunk +163 lines, -0 lines 0 comments Download
A net/quic/core/frames/quic_blocked_frame.h View 1 chunk +31 lines, -0 lines 0 comments Download
A net/quic/core/frames/quic_blocked_frame.cc View 1 chunk +19 lines, -0 lines 0 comments Download
A net/quic/core/frames/quic_connection_close_frame.h View 1 chunk +29 lines, -0 lines 0 comments Download
A net/quic/core/frames/quic_connection_close_frame.cc View 1 chunk +21 lines, -0 lines 0 comments Download
A net/quic/core/frames/quic_frame.h View 1 chunk +81 lines, -0 lines 0 comments Download
A net/quic/core/frames/quic_frame.cc View 1 chunk +163 lines, -0 lines 0 comments Download
A + net/quic/core/frames/quic_frame_test.cc View 1 chunk +1 line, -1 line 0 comments Download
A net/quic/core/frames/quic_goaway_frame.h View 1 chunk +32 lines, -0 lines 0 comments Download
A net/quic/core/frames/quic_goaway_frame.cc View 1 chunk +29 lines, -0 lines 0 comments Download
A net/quic/core/frames/quic_mtu_discovery_frame.h View 1 chunk +18 lines, -0 lines 0 comments Download
A net/quic/core/frames/quic_padding_frame.h View 1 chunk +31 lines, -0 lines 0 comments Download
A net/quic/core/frames/quic_padding_frame.cc View 1 chunk +17 lines, -0 lines 0 comments Download
A net/quic/core/frames/quic_path_close_frame.h View 1 chunk +32 lines, -0 lines 0 comments Download
A net/quic/core/frames/quic_path_close_frame.cc View 1 chunk +18 lines, -0 lines 0 comments Download
A net/quic/core/frames/quic_ping_frame.h View 1 chunk +18 lines, -0 lines 0 comments Download
A net/quic/core/frames/quic_rst_stream_frame.h View 1 chunk +36 lines, -0 lines 0 comments Download
A net/quic/core/frames/quic_rst_stream_frame.cc View 1 chunk +27 lines, -0 lines 0 comments Download
A net/quic/core/frames/quic_stop_waiting_frame.h View 1 chunk +28 lines, -0 lines 0 comments Download
A net/quic/core/frames/quic_stop_waiting_frame.cc View 1 chunk +23 lines, -0 lines 0 comments Download
A net/quic/core/frames/quic_stream_frame.h View 1 chunk +79 lines, -0 lines 0 comments Download
A net/quic/core/frames/quic_stream_frame.cc View 1 chunk +82 lines, -0 lines 0 comments Download
A net/quic/core/frames/quic_window_update_frame.h View 1 chunk +36 lines, -0 lines 0 comments Download
A net/quic/core/frames/quic_window_update_frame.cc View 1 chunk +22 lines, -0 lines 0 comments Download
D net/quic/core/quic_frames.h View 1 chunk +0 lines, -391 lines 0 comments Download
D net/quic/core/quic_frames.cc View 1 chunk +0 lines, -465 lines 0 comments Download
D net/quic/core/quic_frames_test.cc View 1 chunk +0 lines, -274 lines 0 comments Download
M net/quic/core/quic_packets.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_pending_retransmission.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_transmission_info.h View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 6 (4 generated)
Victor Vasiliev
4 years ago (2016-12-01 15:05:04 UTC) #1
Ryan Hamilton
4 years ago (2016-12-01 15:07:34 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698