Makes InputMethodMus deal with no connection

Makes InputMethodMus deal with no connection

Tests don't always have a connection, so this code should deal well
with that.

BUG=669964
TEST=none
R=moshayedi@chromium.org

Committed: https://crrev.com/fe7cb8ebe1880c4dc76e9e95bf50cc3034eb4c9e
Cr-Commit-Position: refs/heads/master@{#435413}

[sky, 2016-11-30 18:04:27]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 18:05:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-11-30 18:22:56]

On 2016/11/30 18:04:16, sky wrote:

Actually, hold off on reviewing. I'm going to add a bit more to this.

[sky, 2016-11-30 18:31:15]

Ok, this is ready for review.

[sky, 2016-11-30 18:31:20]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 18:32:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 19:38:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 19:38:34]

Dry run: This issue passed the CQ dry run.

[Hadi, 2016-11-30 20:34:53]

On 2016/11/30 18:31:15, sky wrote:
> Ok, this is ready for review.

It seems that similar files in ui/views/mus and ui/aura/mus are diverging. Just
for my understanding, what is the plan here?

[Hadi, 2016-11-30 20:34:53]

On 2016/11/30 18:31:15, sky wrote:
> Ok, this is ready for review.

It seems that similar files in ui/views/mus and ui/aura/mus are diverging. Just
for my understanding, what is the plan here?

[sky, 2016-11-30 20:45:24]

On Wed, Nov 30, 2016 at 12:34 PM,  <moshayedi@chromium.org> wrote:
> On 2016/11/30 18:31:15, sky wrote:
>> Ok, this is ready for review.
>
> It seems that similar files in ui/views/mus and ui/aura/mus are diverging.
> Just
> for my understanding, what is the plan here?

Sorry if this wasn't clear in the meetings about aura-mus. aura-mus is
the long term plan, so ui/views/mus/input_method_mus will eventually
be removed.

  -Scott

>
> https://codereview.chromium.org/2545543002/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Hadi, 2016-11-30 20:59:59]

> Sorry if this wasn't clear in the meetings about aura-mus. aura-mus is
> the long term plan, so ui/views/mus/input_method_mus will eventually
> be removed.

Thanks. lgtm.

[sky, 2016-11-30 21:00:29]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2016-11-30 21:00:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 21:05:30]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480539629492940,
"parent_rev": "2cd0b25267685e53c35de4ef6475a60544bfa84b", "commit_rev":
"eac664e1549c41a707ff16375c3fc98eebfb73cd"}

[commit-bot: I haz the power, 2016-11-30 21:05:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-30 21:09:55]

Description was changed from

==========
Makes InputMethodMus deal with no connection

Tests don't always have a connection, so this code should deal well
with that.

BUG=669964
TEST=none
R=moshayedi@chromium.org
==========

to

==========
Makes InputMethodMus deal with no connection

Tests don't always have a connection, so this code should deal well
with that.

BUG=669964
TEST=none
R=moshayedi@chromium.org

Committed: https://crrev.com/fe7cb8ebe1880c4dc76e9e95bf50cc3034eb4c9e
Cr-Commit-Position: refs/heads/master@{#435413}
==========

[commit-bot: I haz the power, 2016-11-30 21:09:56]

Patchset 2 (id:??) landed as
https://crrev.com/fe7cb8ebe1880c4dc76e9e95bf50cc3034eb4c9e
Cr-Commit-Position: refs/heads/master@{#435413}