Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2545543002: Makes InputMethodMus deal with no connection (Closed)

Created:
4 years ago by sky
Modified:
4 years ago
Reviewers:
Hadi
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes InputMethodMus deal with no connection Tests don't always have a connection, so this code should deal well with that. BUG=669964 TEST=none R=moshayedi@chromium.org Committed: https://crrev.com/fe7cb8ebe1880c4dc76e9e95bf50cc3034eb4c9e Cr-Commit-Position: refs/heads/master@{#435413}

Patch Set 1 #

Patch Set 2 : moar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M ui/aura/mus/input_method_mus.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/mus/input_method_mus.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M ui/aura/mus/window_tree_host_mus.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/aura/mus/window_tree_host_mus.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
sky
4 years ago (2016-11-30 18:04:16 UTC) #1
sky
On 2016/11/30 18:04:16, sky wrote: Actually, hold off on reviewing. I'm going to add a ...
4 years ago (2016-11-30 18:22:56 UTC) #4
sky
Ok, this is ready for review.
4 years ago (2016-11-30 18:31:15 UTC) #5
Hadi
On 2016/11/30 18:31:15, sky wrote: > Ok, this is ready for review. It seems that ...
4 years ago (2016-11-30 20:34:53 UTC) #10
Hadi
On 2016/11/30 18:31:15, sky wrote: > Ok, this is ready for review. It seems that ...
4 years ago (2016-11-30 20:34:53 UTC) #11
sky
On Wed, Nov 30, 2016 at 12:34 PM, <moshayedi@chromium.org> wrote: > On 2016/11/30 18:31:15, sky ...
4 years ago (2016-11-30 20:45:24 UTC) #12
Hadi
> Sorry if this wasn't clear in the meetings about aura-mus. aura-mus is > the ...
4 years ago (2016-11-30 20:59:59 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2545543002/20001
4 years ago (2016-11-30 21:00:59 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-30 21:05:56 UTC) #17
commit-bot: I haz the power
4 years ago (2016-11-30 21:09:56 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fe7cb8ebe1880c4dc76e9e95bf50cc3034eb4c9e
Cr-Commit-Position: refs/heads/master@{#435413}

Powered by Google App Engine
This is Rietveld 408576698