Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2545533002: [Merge-M56] arc: Fix duplicate icons in app launcher in case of crash. (Closed)

Created:
4 years ago by khmel
Modified:
4 years ago
Reviewers:
xiyuan
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[Merge-M56] arc: Fix duplicate icons in app launcher in case of crash. This CL initializes tracking items by existing app set on start in order to prevent race condition that leads to arc app created is called twice for some apps. TBR=xiyuan@chromium.org NOTRY=true NOPRESUBMIT=true TEST=Extended unit_tests TEST=Manually on device with chrome://inducebrowsercrashforrealz BUG=b/32765086 BUG=667529 Review-Url: https://codereview.chromium.org/2520173002 Cr-Commit-Position: refs/heads/master@{#433980} (cherry picked from commit 4e1e8774f3b147906917dbd4e50f30bfc7372ba6)

Patch Set 1 #

Patch Set 2 : fix resolution #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -43 lines) Patch
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_test.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_test.cc View 1 4 chunks +35 lines, -28 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_unittest.cc View 9 chunks +67 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2545533002/20001
4 years ago (2016-11-30 19:14:45 UTC) #3
commit-bot: I haz the power
4 years ago (2016-11-30 19:20:37 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698