Issue 254553003: Generate escape sequence for non-printable ascii characters

Issue 254553003: Generate escape sequence for non-printable ascii characters (Closed)

Created:
6 years, 8 months ago by hausner

Modified:
6 years, 8 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Generate escape sequence for non-printable ascii characters Fix issue 17857. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=35411

Patch Set 2 : #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -32 lines)			Patch
M	runtime/tests/vm/vm.status	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	runtime/vm/object.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	6 chunks	+66 lines, -28 lines	0 comments	Download
M	runtime/vm/snapshot_test.cc	View	1	2 chunks	+4 lines, -1 line	0 comments	Download
M	runtime/vm/unit_test.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTMwC -ip https://codereview.chromium.org/254553003/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/254553003/diff/1/runtime/vm/object.cc#newcode375 runtime/vm/object.cc:375: ((0 <= c) && (c < 32)) ...

6 years, 8 months ago (2014-04-24 21:02:14 UTC) #2

hausner

Thanks https://codereview.chromium.org/254553003/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/254553003/diff/1/runtime/vm/object.cc#newcode375 runtime/vm/object.cc:375: ((0 <= c) && (c < 32)) || ...

6 years, 8 months ago (2014-04-24 21:30:28 UTC) #3

hausner

6 years, 8 months ago (2014-04-24 22:56:03 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r35411 (presubmit successful).

Expand Messages | Collapse Messages