As YAPS server does not handle affiliation_ids correctly yet, we need to have a flag that would al…

As YAPS server does not handle affiliation_ids correctly yet, we need to  have a flag that would allow us to avoid that check during development.

Committed: https://crrev.com/40d29fca0496fb641c03734134cf27453a002ab3
Cr-Commit-Position: refs/heads/master@{#435777}

[Denis Kuznetsov (DE-MUC), 2016-11-30 20:16:13]

antrim@chromium.org changed reviewers:
+ atwilson@chromium.org

[Andrew T Wilson (Slow), 2016-12-01 09:35:38]

atwilson@chromium.org changed reviewers:
+ peletskyi@chromium.org

[Andrew T Wilson (Slow), 2016-12-01 09:35:39]

LGTM, but probably sasha should take a look to see if I'm missing any subtleties

https://codereview.chromium.org/2545523003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/users/affiliation.cc (right):

https://codereview.chromium.org/2545523003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/users/affiliation.cc:37: if (email.empty() ||
email.find('@') == std::string::npos) {
Note that guests will not appear to be affiliated with your change. I think I'm
OK with that.

https://codereview.chromium.org/2545523003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/users/affiliation.cc:45: // Not all test servers
correctly support affiliation ids so far, so
complete comment.

[peletskyi, 2016-12-01 11:31:42]

On 2016/12/01 09:35:39, Andrew T Wilson (Slow) wrote:
> LGTM, but probably sasha should take a look to see if I'm missing any
subtleties
> 
>
https://codereview.chromium.org/2545523003/diff/1/chrome/browser/chromeos/log...
> File chrome/browser/chromeos/login/users/affiliation.cc (right):
> 
>
https://codereview.chromium.org/2545523003/diff/1/chrome/browser/chromeos/log...
> chrome/browser/chromeos/login/users/affiliation.cc:37: if (email.empty() ||
> email.find('@') == std::string::npos) {
> Note that guests will not appear to be affiliated with your change. I think
I'm
> OK with that.
> 
>
https://codereview.chromium.org/2545523003/diff/1/chrome/browser/chromeos/log...
> chrome/browser/chromeos/login/users/affiliation.cc:45: // Not all test servers
> correctly support affiliation ids so far, so
> complete comment.

LGTM

[Denis Kuznetsov (DE-MUC), 2016-12-01 14:59:43]

The CQ bit was checked by antrim@chromium.org

[Denis Kuznetsov (DE-MUC), 2016-12-01 14:59:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
atwilson@chromium.org, peletskyi@chromium.org
Link to the patchset: https://codereview.chromium.org/2545523003/#ps20001
(title: "Added comments")

[commit-bot: I haz the power, 2016-12-01 14:59:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 15:05:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 15:05:15]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Denis Kuznetsov (DE-MUC), 2016-12-01 15:29:29]

antrim@chromium.org changed reviewers:
+ alemate@chromium.org

[Denis Kuznetsov (DE-MUC), 2016-12-01 15:30:01]

+alemate as 	chrome/browser/chromeos/login/users/affiliation.cc owner

[Alexander Alekseev, 2016-12-01 23:50:28]

lgtm

[Alexander Alekseev, 2016-12-01 23:50:37]

The CQ bit was checked by alemate@chromium.org

[commit-bot: I haz the power, 2016-12-01 23:51:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 23:57:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480636237201630,
"parent_rev": "34b35923541d60744abe9f306201ba61778dfac2", "commit_rev":
"01d65683e5740befa459408677435c810221ce31"}

[commit-bot: I haz the power, 2016-12-01 23:57:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-02 00:00:40]

Description was changed from

==========
As YAPS server does not handle affiliation_ids correctly yet, we need to  have a
flag that would allow us to avoid that check during development.
==========

to

==========
As YAPS server does not handle affiliation_ids correctly yet, we need to  have a
flag that would allow us to avoid that check during development.

Committed: https://crrev.com/40d29fca0496fb641c03734134cf27453a002ab3
Cr-Commit-Position: refs/heads/master@{#435777}
==========

[commit-bot: I haz the power, 2016-12-02 00:00:41]

Patchset 2 (id:??) landed as
https://crrev.com/40d29fca0496fb641c03734134cf27453a002ab3
Cr-Commit-Position: refs/heads/master@{#435777}