Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2545473002:
TransformationMatrix::inverse should use multiplication instead of division (Closed)
DescriptionTransformationMatrix::inverse should use multiplication instead of division
Microbenchmark: Execute 1 million matrix inversion in a for loop.
Result: (measured on Arndale Octa board - Cortex-A15)
| | before(ms)| after(ms) | Speedup |
| GCC 4.8.2 | 7545 | 2575 | 2.93x |
| Clang 4.0.0 (trunk 287685) | 8260 | 3555 | 2.32x |
BUG=669838
Committed: https://crrev.com/97e30b35dd6b89ee97f08cf467c80df5d3369fa5
Cr-Commit-Position: refs/heads/master@{#436920}
Patch Set 1 #
Messages
Total messages: 17 (8 generated)
Description was changed from ========== TransformationMatrix::inverse should use multiplication instead of division Microbenchmark: Execute 1 million matrix inversion in a for loop. Result: (measured on Arndale Octa board - Cortex-A15) | | before(ms)| after(ms) | Speedup | | GCC 4.8.2 | 7545 | 2575 | 2.93x | | Clang 4.0.0 (trunk 287685) | 8260 | 3555 | 2.32x | BUG=669838 ========== to ========== TransformationMatrix::inverse should use multiplication instead of division Microbenchmark: Execute 1 million matrix inversion in a for loop. Result: (measured on Arndale Octa board - Cortex-A15) | | before(ms)| after(ms) | Speedup | | GCC 4.8.2 | 7545 | 2575 | 2.93x | | Clang 4.0.0 (trunk 287685) | 8260 | 3555 | 2.32x | BUG=669838 ==========
ossy.szeged@gmail.com changed reviewers: + esprehn@chromium.org, schenney@chromium.org
Great. LGTM.
The CQ bit was checked by pgal.u-szeged@partner.samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
On 2016/11/30 18:20:45, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) fast/dom/geometry-interfaces-dom-matrix-readonly-inverse.html fast/dom/geometry-interfaces-dom-matrix-invert.html These tests fail because of minor rounding issue. I think the bug isn't in my CL, but in these tests themself. I'm proposing to fix these tests: https://bugs.chromium.org/p/chromium/issues/detail?id=671173
On 2016/12/05 13:36:10, Ossy wrote: > On 2016/11/30 18:20:45, commit-bot: I haz the power wrote: > > Try jobs failed on following builders: > > linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, > > > http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) > > fast/dom/geometry-interfaces-dom-matrix-readonly-inverse.html > fast/dom/geometry-interfaces-dom-matrix-invert.html > > These tests fail because of minor rounding issue. I think the bug isn't in my > CL, > but in these tests themself. I'm proposing to fix these tests: > https://bugs.chromium.org/p/chromium/issues/detail?id=671173 Yes, you should definitely fix the tests. You could do it in this patch or another; I don't mind at all.
The CQ bit was checked by pgal.u-szeged@partner.samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481106226199310, "parent_rev":
"ed0c22a7160d357fb92c7785fede18350e32c02d", "commit_rev":
"a7fc41ad556311264548cf7c6193b2626e475605"}
Message was sent while issue was closed.
Description was changed from ========== TransformationMatrix::inverse should use multiplication instead of division Microbenchmark: Execute 1 million matrix inversion in a for loop. Result: (measured on Arndale Octa board - Cortex-A15) | | before(ms)| after(ms) | Speedup | | GCC 4.8.2 | 7545 | 2575 | 2.93x | | Clang 4.0.0 (trunk 287685) | 8260 | 3555 | 2.32x | BUG=669838 ========== to ========== TransformationMatrix::inverse should use multiplication instead of division Microbenchmark: Execute 1 million matrix inversion in a for loop. Result: (measured on Arndale Octa board - Cortex-A15) | | before(ms)| after(ms) | Speedup | | GCC 4.8.2 | 7545 | 2575 | 2.93x | | Clang 4.0.0 (trunk 287685) | 8260 | 3555 | 2.32x | BUG=669838 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== TransformationMatrix::inverse should use multiplication instead of division Microbenchmark: Execute 1 million matrix inversion in a for loop. Result: (measured on Arndale Octa board - Cortex-A15) | | before(ms)| after(ms) | Speedup | | GCC 4.8.2 | 7545 | 2575 | 2.93x | | Clang 4.0.0 (trunk 287685) | 8260 | 3555 | 2.32x | BUG=669838 ========== to ========== TransformationMatrix::inverse should use multiplication instead of division Microbenchmark: Execute 1 million matrix inversion in a for loop. Result: (measured on Arndale Octa board - Cortex-A15) | | before(ms)| after(ms) | Speedup | | GCC 4.8.2 | 7545 | 2575 | 2.93x | | Clang 4.0.0 (trunk 287685) | 8260 | 3555 | 2.32x | BUG=669838 Committed: https://crrev.com/97e30b35dd6b89ee97f08cf467c80df5d3369fa5 Cr-Commit-Position: refs/heads/master@{#436920} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/97e30b35dd6b89ee97f08cf467c80df5d3369fa5 Cr-Commit-Position: refs/heads/master@{#436920} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
