Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2545433004: kiosk: Use ContextMenuContentTypeAppMode when in app mode (Closed)

Created:
4 years ago by xiyuan
Modified:
4 years ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, lazyboy
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

kiosk: Use ContextMenuContentTypeAppMode when in app mode Give ContextMenuContentTypeAppMode higher priority than ContextMenuContentTypeWebView so that webview in kiosk mode does not show undesired context menu. BUG=656188 Committed: https://crrev.com/8791e3898c6d8c25fdfc416bb0c427607f223851 Cr-Commit-Position: refs/heads/master@{#435429}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/renderer_context_menu/context_menu_content_type_factory.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
xiyuan
avi@, could you help with the review? Thanks.
4 years ago (2016-11-30 20:43:01 UTC) #2
Avi (use Gerrit)
lgtm
4 years ago (2016-11-30 21:06:25 UTC) #5
xiyuan
Thanks for the quick review.
4 years ago (2016-11-30 21:18:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2545433004/1
4 years ago (2016-11-30 21:43:37 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 21:49:46 UTC) #12
commit-bot: I haz the power
4 years ago (2016-11-30 21:53:14 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8791e3898c6d8c25fdfc416bb0c427607f223851
Cr-Commit-Position: refs/heads/master@{#435429}

Powered by Google App Engine
This is Rietveld 408576698