Move processing of instantiated classes from ResolutionEnqueuer to ResolutionWorldBuilderImpl

Move processing of instantiated classes from ResolutionEnqueuer to ResolutionWorldBuilderImpl

R=het@google.com

Committed: https://github.com/dart-lang/sdk/commit/61d10296ee1a2b7bfe6710861960523080c0e737

[Johnni Winther, 2016-12-05 11:12:23]

johnniwinther@google.com changed reviewers:
+ het@google.com

[Harry Terkelsen, 2016-12-05 23:18:12]

lgtm

https://codereview.chromium.org/2545413002/diff/20001/pkg/compiler/lib/src/un...
File pkg/compiler/lib/src/universe/world_builder.dart (right):

https://codereview.chromium.org/2545413002/diff/20001/pkg/compiler/lib/src/un...
pkg/compiler/lib/src/universe/world_builder.dart:514: ||
nitpick: I've been moving these '||' to the end of the line before the comments
to make dartfmt happy

https://codereview.chromium.org/2545413002/diff/20001/pkg/compiler/lib/src/un...
pkg/compiler/lib/src/universe/world_builder.dart:775: while (cls != null &&
processClass(cls)) {
is the assumption that we stop going up the superclass chain because once one
has been instantiated then all of the rest up the chain must also be
instantiated?

https://codereview.chromium.org/2545413002/diff/20001/pkg/compiler/lib/src/un...
pkg/compiler/lib/src/universe/world_builder.dart:1447: class ClassUse {
same comment as with MemberUse, can't this be an enum?

[Johnni Winther, 2016-12-06 09:54:19]

Description was changed from

==========
Move processing of instantiated classes from ResolutionEnqueuer to
ResolutionWorldBuilderImpl
==========

to

==========
Move processing of instantiated classes from ResolutionEnqueuer to
ResolutionWorldBuilderImpl

R=het@google.com

Committed:
https://github.com/dart-lang/sdk/commit/61d10296ee1a2b7bfe6710861960523080c0e737
==========

[Johnni Winther, 2016-12-06 09:54:20]

Committed patchset #3 (id:40001) manually as
61d10296ee1a2b7bfe6710861960523080c0e737 (presubmit successful).

[Johnni Winther, 2016-12-06 09:58:42]

https://codereview.chromium.org/2545413002/diff/20001/pkg/compiler/lib/src/un...
File pkg/compiler/lib/src/universe/world_builder.dart (right):

https://codereview.chromium.org/2545413002/diff/20001/pkg/compiler/lib/src/un...
pkg/compiler/lib/src/universe/world_builder.dart:514: ||
On 2016/12/05 23:18:12, Harry Terkelsen wrote:
> nitpick: I've been moving these '||' to the end of the line before the
comments
> to make dartfmt happy

Done.

https://codereview.chromium.org/2545413002/diff/20001/pkg/compiler/lib/src/un...
pkg/compiler/lib/src/universe/world_builder.dart:775: while (cls != null &&
processClass(cls)) {
On 2016/12/05 23:18:12, Harry Terkelsen wrote:
> is the assumption that we stop going up the superclass chain because once one
> has been instantiated then all of the rest up the chain must also be
> instantiated?

Yes. Added as comment.

https://codereview.chromium.org/2545413002/diff/20001/pkg/compiler/lib/src/un...
pkg/compiler/lib/src/universe/world_builder.dart:1447: class ClassUse {
On 2016/12/05 23:18:12, Harry Terkelsen wrote:
> same comment as with MemberUse, can't this be an enum?

Done.