Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2545393002: [turbofan] Properly check Tagged->Word32 changes. (Closed)

Created:
4 years ago by Benedikt Meurer
Modified:
4 years ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Properly check Tagged->Word32 changes. Don't unconditionally assume that Tagged->Word32 changes are always truncating independent of the type of the input. Work-around the remaining issues with for-in by properly renaming the index if it's not already of appropriate type (happens with generators or OSR). R=jarin@chromium.org Committed: https://crrev.com/bf5c5bf8a498031b3a9fa52fbe511b8e6d9a86ad Cr-Commit-Position: refs/heads/master@{#41484}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/compiler/representation-change.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-representation-change.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Benedikt Meurer
4 years ago (2016-12-05 09:53:14 UTC) #1
Jarin
lgtm
4 years ago (2016-12-05 11:54:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2545393002/1
4 years ago (2016-12-05 11:54:57 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 11:56:57 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-05 11:57:24 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf5c5bf8a498031b3a9fa52fbe511b8e6d9a86ad
Cr-Commit-Position: refs/heads/master@{#41484}

Powered by Google App Engine
This is Rietveld 408576698