Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Issue 2545363002: Use HTTPS links for Google domains in docs (Closed)

Created:
4 years ago by Xiaoyin Liu
Modified:
4 years ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use HTTPS links for Google domains in docs Since almost all Google domains support HTTPS, and it is a good practice to use HTTPS wherever possible, thus in this patch, I changed most HTTP links to https whose domains are known to support HTTPS well. Modifications are generated by running these commands in src/docs directory: sed -i 's/http:\/\/www.chromium.org/https:\/\/www.chromium.org/g' *.md sed -i 's/http:\/\/developer.android.com/https:\/\/developer.android.com/g' *.md sed -i 's/http:\/\/dev.chromium.org/https:\/\/dev.chromium.org/g' *.md sed -i 's/http:\/\/build.chromium.org/https:\/\/build.chromium.org/g' *.md sed -i 's/http:\/\/src.chromium.org/https:\/\/src.chromium.org/g' *.md sed -i 's/http:\/\/crbug.com/https:\/\/crbug.com/g' *.md sed -i 's/http:\/\/groups.google.com/https:\/\/groups.google.com/g' *.md sed -i 's/http:\/\/cs.chromium.org/https:\/\/cs.chromium.org/g' *.md sed -i 's/http:\/\/codereview.chromium.org/https:\/\/codereview.chromium.org/g' *.md BUG= Committed: https://crrev.com/1003c0bc03baee199255235af2484c2a2137a4b7 Cr-Commit-Position: refs/heads/master@{#436501}

Patch Set 1 #

Patch Set 2 : Modify two more files in subdirectories #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -82 lines) Patch
M docs/android_build_instructions.md View 4 chunks +5 lines, -5 lines 0 comments Download
M docs/android_logging.md View 2 chunks +2 lines, -2 lines 0 comments Download
M docs/android_test_instructions.md View 2 chunks +2 lines, -2 lines 0 comments Download
M docs/browser_view_resizer.md View 2 chunks +2 lines, -2 lines 0 comments Download
M docs/chromium_browser_vs_google_chrome.md View 1 chunk +1 line, -1 line 0 comments Download
M docs/chromoting_android_hacking.md View 1 chunk +1 line, -1 line 0 comments Download
M docs/clang.md View 2 chunks +3 lines, -3 lines 0 comments Download
M docs/clang_format.md View 2 chunks +2 lines, -2 lines 0 comments Download
M docs/closure_compilation.md View 2 chunks +2 lines, -2 lines 0 comments Download
M docs/common_build_tasks.md View 2 chunks +2 lines, -2 lines 0 comments Download
M docs/git_cookbook.md View 2 chunks +2 lines, -2 lines 0 comments Download
M docs/gtk_vs_views_gtk.md View 1 chunk +3 lines, -3 lines 0 comments Download
M docs/ios_build_instructions.md View 1 chunk +1 line, -1 line 0 comments Download
M docs/linux_chromium_arm.md View 1 chunk +2 lines, -2 lines 0 comments Download
M docs/linux_debugging.md View 4 chunks +4 lines, -4 lines 0 comments Download
M docs/linux_development.md View 1 chunk +1 line, -1 line 0 comments Download
M docs/linux_minidump_to_core.md View 1 chunk +1 line, -1 line 0 comments Download
M docs/linux_plugins.md View 1 chunk +1 line, -1 line 0 comments Download
M docs/linux_profiling.md View 2 chunks +2 lines, -2 lines 0 comments Download
M docs/linux_sandboxing.md View 4 chunks +6 lines, -6 lines 0 comments Download
M docs/linux_suid_sandbox.md View 1 chunk +1 line, -1 line 0 comments Download
M docs/mac_build_instructions.md View 2 chunks +3 lines, -3 lines 0 comments Download
M docs/memory-infra/probe-cc.md View 1 1 chunk +1 line, -1 line 0 comments Download
M docs/old_chromoting_build_instructions.md View 1 chunk +1 line, -1 line 0 comments Download
M docs/ozone_overview.md View 3 chunks +3 lines, -3 lines 0 comments Download
M docs/piranha_plant.md View 1 chunk +1 line, -1 line 0 comments Download
M docs/profiling_content_shell_on_android.md View 1 chunk +1 line, -1 line 0 comments Download
M docs/retrieving_code_analysis_warnings.md View 1 chunk +1 line, -1 line 0 comments Download
M docs/system_hardening_features.md View 1 chunk +1 line, -1 line 0 comments Download
M docs/testing/writing_layout_tests.md View 1 1 chunk +1 line, -1 line 0 comments Download
M docs/use_find_bugs_for_android.md View 1 chunk +2 lines, -2 lines 0 comments Download
M docs/useful_urls.md View 2 chunks +13 lines, -13 lines 0 comments Download
M docs/webview_policies.md View 1 chunk +2 lines, -2 lines 0 comments Download
M docs/windows_build_instructions.md View 1 chunk +1 line, -1 line 0 comments Download
M docs/windows_split_dll.md View 1 chunk +4 lines, -4 lines 0 comments Download
M docs/writing_clang_plugins.md View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Xiaoyin Liu
Please have a look. Thanks for your reviewing!
4 years ago (2016-12-05 02:38:28 UTC) #3
Dirk Pranke
lgtm, thanks!
4 years ago (2016-12-06 02:42:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2545363002/20001
4 years ago (2016-12-06 02:42:43 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-06 02:51:49 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-06 02:54:03 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1003c0bc03baee199255235af2484c2a2137a4b7
Cr-Commit-Position: refs/heads/master@{#436501}

Powered by Google App Engine
This is Rietveld 408576698