build/android/AndroidManifest.xml - Issue 2545343002: Add support for virtual files to Clank.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/android/AndroidManifest.xml

Issue 2545343002: Add support for virtual files to Clank. (Closed)

Patch Set: Add support for virtual files to Clank. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « base/android/java/src/org/chromium/base/ContentUriUtils.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBarDelegateAndroid.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!--	2 <!--

3 Copyright (c) 2012 The Chromium Authors. All rights reserved. Use of this	3 Copyright (c) 2012 The Chromium Authors. All rights reserved. Use of this

4 source code is governed by a BSD-style license that can be found in the	4 source code is governed by a BSD-style license that can be found in the

5 LICENSE file.	5 LICENSE file.

6 -->	6 -->

7	7

8 <!--	8 <!--

9 This is a dummy manifest which is required by:	9 This is a dummy manifest which is required by:

10 1. aapt when generating R.java in java.gypi:	10 1. aapt when generating R.java in java.gypi:

11 Nothing in the manifest is used, but it is still required by aapt.	11 Nothing in the manifest is used, but it is still required by aapt.

12 2. lint: [min\|target]SdkVersion are required by lint and should	12 2. lint: [min\|target]SdkVersion are required by lint and should

13 be kept up to date.	13 be kept up to date.

14 -->	14 -->

15 <manifest xmlns:android="http://schemas.android.com/apk/res/android"	15 <manifest xmlns:android="http://schemas.android.com/apk/res/android"

16 package="dummy.package">	16 package="dummy.package">

17	17

18 <uses-sdk android:minSdkVersion="16" android:targetSdkVersion="23" />	18 <uses-sdk android:minSdkVersion="16" android:targetSdkVersion="24" />
	agrieve 2016/12/12 18:33:41 Please make a separate CL to bump this number. Please make a separate CL to bump this number. mtomasz 2016/12/13 08:19:25 This CL needs a bump, and bump is not needed witho Show quoted text On 2016/12/12 18:33:41, agrieve wrote: > Please make a separate CL to bump this number. This CL needs a bump, and bump is not needed without this CL, so what's the purpose of splitting this into a separate CL? agrieve 2016/12/13 14:46:55 There's code in the Android runtime that looks lik Show quoted text On 2016/12/13 08:19:25, mtomasz wrote: > On 2016/12/12 18:33:41, agrieve wrote: > > Please make a separate CL to bump this number. > > This CL needs a bump, and bump is not needed without this CL, so what's the > purpose of splitting this into a separate CL? There's code in the Android runtime that looks like if (app.targetSdk < ##) { // do one thing } else { // do another. } So I think it's important to have the CL description be "Update targetSdk version", so that if bumping the targetSdk breaks anything, it'll be obvious when looking at git log --oneline.
19	19

20 </manifest>	20 </manifest>

OLD	NEW