Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
254533003:
[2/4] Process clearBrowserCahce/cookies commands in browser. (Closed)
|
Created:
6 years, 8 months ago by eustas Modified:
6 years, 7 months ago Reviewers:
pfeldman CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
Description[2/4] Process clearBrowserCahce/cookies commands in browser.
BUG=366585
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266553
Patch Set 1 #
Total comments: 2
Patch Set 2 : Addressed comments #
Messages
Total messages: 22 (0 generated)
lgtm https://codereview.chromium.org/254533003/diff/1/content/browser/devtools/ren... File content/browser/devtools/renderer_overrides_handler.cc (right): https://codereview.chromium.org/254533003/diff/1/content/browser/devtools/ren... content/browser/devtools/renderer_overrides_handler.cc:308: return command->InternalErrorResponse("No WebContents"); You don't need this check.
https://codereview.chromium.org/254533003/diff/1/content/browser/devtools/ren... File content/browser/devtools/renderer_overrides_handler.cc (right): https://codereview.chromium.org/254533003/diff/1/content/browser/devtools/ren... content/browser/devtools/renderer_overrides_handler.cc:308: return command->InternalErrorResponse("No WebContents"); On 2014/04/25 15:24:20, pfeldman wrote: > You don't need this check. Done.
The CQ bit was checked by eustas@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/254533003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
The CQ bit was checked by eustas@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/254533003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
The CQ bit was checked by eustas@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/254533003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
The CQ bit was checked by eustas@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/254533003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
The CQ bit was checked by eustas@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/254533003/20001
Message was sent while issue was closed.
Change committed as 266553 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
