Implemented stub ShareService mojo service, for navigator.share.

chrome/browser/webshare/share_service_impl.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/webshare/share_service_impl.h"
+
+ShareServiceImpl::ShareServiceImpl(blink::mojom::ShareServiceRequest request)
+    : binding_(this) {
+  binding_.Bind(std::move(request));
+}
+
+ShareServiceImpl::~ShareServiceImpl() {}

[Sam McNally, 2016/12/09 04:23:45]

= default;

[constantina, 2016/12/12 02:50:32]

Done.

[Matt Giuca, 2016/12/12 04:33:04]

I think this still has to be in the .cc file to avoid it being duplicated in all
the clients. Does it work if you write that here:

ShareServiceImpl::~ShareServiceImpl() = default;

?

+
+// static
+void ShareServiceImpl::Create(mojo::InterfaceRequest<ShareService> request) {

[Sam McNally, 2016/12/09 04:23:45]

s/mojo::InterfaceRequest<ShareService>/ShareServiceRequest/

[constantina, 2016/12/12 02:50:32]

Done.

+  new ShareServiceImpl(std::move(request));

[Sam McNally, 2016/12/09 04:23:45]

This will leak the ShareServiceImpl. Use StrongBinding instead:

mojo::MakeStrongBinding(base::MakeUnique<ShareServiceImpl>(),
                        std::move(request));

and remove |binding_|.

[constantina, 2016/12/12 02:50:32]

Done.

+}
+
+void ShareServiceImpl::Share(const std::string& title,
+                             const std::string& text,
+                             const GURL& url,
+                             const ShareCallback& callback) {
+  // TODO(constantina): Implement Web Share Target here.
+  NOTIMPLEMENTED();
+  callback.Run(base::Optional<std::string>("Not implemented: navigator.share"));
+}