Implemented stub ShareService mojo service, for navigator.share.

chrome/browser/webshare/share_service_impl.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/webshare/share_service_impl.h"
+
+ShareServiceImpl::ShareServiceImpl(blink::mojom::ShareServiceRequest request)
+    : binding_(this) {
+  binding_.Bind(std::move(request));
+}
+
+ShareServiceImpl::~ShareServiceImpl() {}
+
+// static
+void ShareServiceImpl::Create(mojo::InterfaceRequest<ShareService> request) {
+  new ShareServiceImpl(std::move(request));
+}
+
+void ShareServiceImpl::Share(const std::string& title,
+                             const std::string& text,
+                             const GURL& url,
+                             const ShareCallback& callback) {
+  NOTIMPLEMENTED() << "Share called";

[Matt Giuca, 2016/12/08 06:42:56]

Add TODO(constantina): ....

Explain briefly that you plan to implement WST here.

[Matt Giuca, 2016/12/08 06:42:56]

Get rid of the string (just "NOTIMPLEMENTED();").

If you look at the log message, it is quite verbose as it is:

[25461:25461:1208/173659.851063:ERROR:share_service_impl.cc(23)] Not implemented
reached in virtual void ShareServiceImpl::Share(const std::string &, const
std::string &, const GURL &, const ShareCallback &)Share called

So there is no need to write "Share called", and FYI if you do, you have to put
a space in front of it or it looks ugly.

[constantina, 2016/12/09 02:24:14]

Done.

[constantina, 2016/12/09 02:24:14]

Done.

[Matt Giuca, 2016/12/09 02:32:21]

nit: No "@" in the TODO; capital "I" in "Implement".

[constantina, 2016/12/09 03:48:27]

Done.

+  callback.Run(base::Optional<std::string>("Not implemented: navigator.share"));
+}