Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 2545313002: Fix typo in Windows Build Instructions (Closed)

Created:
4 years ago by Xiaoyin Liu
Modified:
4 years ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix typo in Windows Build Instructions In the "Get the code" section, shouldn't it be "fetch chromium"? As it is unlikely that people who build Chromium on Windows want to target iOS. Also this is my first patch submission, so I think I also need to add my name to the AUTHORS file. BUG= Committed: https://crrev.com/802e4b3e77d7201234c4d41f2378d376574fdd18 Cr-Commit-Position: refs/heads/master@{#436203}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M docs/windows_build_instructions.md View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 15 (10 generated)
Xiaoyin Liu
4 years ago (2016-12-04 16:48:20 UTC) #3
Dirk Pranke
lgtm. Thanks for the fix, and welcome to contributing! https://codereview.chromium.org/2545313002/diff/1/docs/windows_build_instructions.md File docs/windows_build_instructions.md (right): https://codereview.chromium.org/2545313002/diff/1/docs/windows_build_instructions.md#newcode102 docs/windows_build_instructions.md:102: ...
4 years ago (2016-12-04 22:05:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2545313002/1
4 years ago (2016-12-04 22:05:53 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-04 22:17:55 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-04 22:19:24 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/802e4b3e77d7201234c4d41f2378d376574fdd18
Cr-Commit-Position: refs/heads/master@{#436203}

Powered by Google App Engine
This is Rietveld 408576698