Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2545303002: Rename CheckNum to MakeCheckedNum (Closed)

Created:
4 years ago by jschuh
Modified:
4 years ago
Reviewers:
dcheng
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename CheckNum to MakeCheckedNum R=dcheng@chromium.org TBR=dcheng@chromium.org Committed: https://crrev.com/4bc919cb5fefe592d85911690b5ae3688c09838d Cr-Commit-Position: refs/heads/master@{#436193}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -26 lines) Patch
M base/numerics/safe_math.h View 3 chunks +4 lines, -4 lines 0 comments Download
M base/numerics/safe_numerics_unittest.cc View 5 chunks +26 lines, -22 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2545303002/20001
4 years ago (2016-12-04 13:20:45 UTC) #3
jschuh
Hope you don't mind the TBR since we talked about this yesterday and you seemed ...
4 years ago (2016-12-04 13:21:28 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years ago (2016-12-04 15:08:58 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4bc919cb5fefe592d85911690b5ae3688c09838d Cr-Commit-Position: refs/heads/master@{#436193}
4 years ago (2016-12-04 15:11:29 UTC) #8
dcheng
4 years ago (2016-12-04 19:10:39 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698