Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
254523003:
Policy docs: Mention that policies for unreleased versions are subject to change. (Closed)
|
Created:
6 years, 8 months ago by Thiemo Nagel Modified:
6 years, 8 months ago Reviewers:
Joao da Silva CC:
chromium-reviews, joaodasilva+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
DescriptionPolicy docs: Mention that policies for unreleased versions are subject to change.
BUG=365663
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266292
Patch Set 1 #
Total comments: 3
Messages
Total messages: 18 (0 generated)
Hi Joao, could you please take a look at this CL, too? It's about a small modification to the introductory text of the HTML documentation. Thank you! Thiemo
https://codereview.chromium.org/254523003/diff/1/components/policy/resources/... File components/policy/resources/policy_templates.json (left): https://codereview.chromium.org/254523003/diff/1/components/policy/resources/... components/policy/resources/policy_templates.json:6378: 'text': '''This is the list of policies that <ph name="PRODUCT_NAME">$1<ex>Google Chrome</ex></ph> respects. Why did you remove this opening sentence? I think the caveat about new policies should come after this, instead of being the first thing in the page. WDYT?
https://codereview.chromium.org/254523003/diff/1/components/policy/resources/... File components/policy/resources/policy_templates.json (left): https://codereview.chromium.org/254523003/diff/1/components/policy/resources/... components/policy/resources/policy_templates.json:6378: 'text': '''This is the list of policies that <ph name="PRODUCT_NAME">$1<ex>Google Chrome</ex></ph> respects. On 2014/04/24 18:11:39, Joao da Silva wrote: > Why did you remove this opening sentence? I felt it was redundant since the title of the wiki page already says "Policy List" and the page starts with the sentence "Last updated for Chrome 34." It's only after this, that the sentence in braces starts. Please have a look: https://sites.google.com/a/chromium.org/dev/administrators/policy-list-3
lgtm https://codereview.chromium.org/254523003/diff/1/components/policy/resources/... File components/policy/resources/policy_templates.json (left): https://codereview.chromium.org/254523003/diff/1/components/policy/resources/... components/policy/resources/policy_templates.json:6378: 'text': '''This is the list of policies that <ph name="PRODUCT_NAME">$1<ex>Google Chrome</ex></ph> respects. On 2014/04/24 18:26:26, Thiemo Nagel wrote: > On 2014/04/24 18:11:39, Joao da Silva wrote: > > Why did you remove this opening sentence? > > I felt it was redundant since the title of the wiki page already says "Policy > List" and the page starts with the sentence "Last updated for Chrome 34." It's > only after this, that the sentence in braces starts. Please have a look: > > https://sites.google.com/a/chromium.org/dev/administrators/policy-list-3 Makes sense, thanks for explaining.
On 2014/04/24 18:29:56, Joao da Silva wrote: > lgtm Thank you!
The CQ bit was checked by tnagel@chromium.org
The CQ bit was unchecked by tnagel@chromium.org
The CQ bit was checked by tnagel@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/254523003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
The CQ bit was checked by tnagel@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/254523003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
The CQ bit was checked by tnagel@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/254523003/1
Message was sent while issue was closed.
Change committed as 266292 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
