Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 2545213002: Refactor Content-Range response header parsing into http_util (Closed)

Created:
4 years ago by sclittle
Modified:
4 years ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor Content-Range response header parsing into http_util Refactor Content-Range response header parsing into http_util so that it's easier for other components to depend on it without needing to go through HttpResponseHeaders. BUG=670913 Committed: https://crrev.com/0a4f767df75c67cf8f068a352997ac89313b0022 Cr-Commit-Position: refs/heads/master@{#436162}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed mmenke comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -104 lines) Patch
M net/http/http_response_headers.cc View 1 chunk +5 lines, -104 lines 0 comments Download
M net/http/http_util.h View 2 chunks +16 lines, -0 lines 0 comments Download
M net/http/http_util.cc View 1 chunk +73 lines, -0 lines 0 comments Download
M net/http/http_util_unittest.cc View 1 2 chunks +65 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
sclittle
Here's the split-out net changes from https://codereview.chromium.org/2543073002/. PTAL
4 years ago (2016-12-03 01:13:52 UTC) #2
mmenke
LGTM. You may have missed my comment on the other CL, but I'm happy to ...
4 years ago (2016-12-03 01:18:49 UTC) #3
sclittle
Thanks for the offer, but I'll just do the API refactor myself. I've already got ...
4 years ago (2016-12-03 01:27:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2545213002/20001
4 years ago (2016-12-03 01:27:46 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-03 03:46:23 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-03 03:48:21 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0a4f767df75c67cf8f068a352997ac89313b0022
Cr-Commit-Position: refs/heads/master@{#436162}

Powered by Google App Engine
This is Rietveld 408576698