components/sync/syncable/directory.cc - Issue 2545173002: [tracing] Remove MemoryAllocatorDump::process_memory_dump

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/syncable/directory.cc

Issue 2545173002: [tracing] Remove MemoryAllocatorDump::process_memory_dump (Closed)

Patch Set: Fix include. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/syncable/directory.cc

diff --git a/components/sync/syncable/directory.cc b/components/sync/syncable/directory.cc

index 31cbb8699719a4695bde6e49d2673c2cf55b84cd..ba417e757a4f322bddbcaa6f6e08ebda9df30b1e 100644

--- a/components/sync/syncable/directory.cc

+++ b/components/sync/syncable/directory.cc

@@ -944,8 +944,7 @@ void Directory::OnMemoryDump(base::trace_event::ProcessMemoryDump* pmd) {

if (store_) {

std::string dump_name =

base::StringPrintf("%s/store", dump_name_base.c_str());

- auto* dump = pmd->CreateAllocatorDump(dump_name);

- store_->ReportMemoryUsage(dump);

+ store_->ReportMemoryUsage(pmd, dump_name);

}