net/dns/dns_protocol.h - Issue 2545163002: net: move kRcodeMask into dns_response.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/dns/dns_protocol.h

Issue 2545163002: net: move kRcodeMask into dns_response.cc (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/dns/dns_protocol.h

diff --git a/net/dns/dns_protocol.h b/net/dns/dns_protocol.h

index f80886338ace3fa680b81ce0ea1540316b8bd133..416738a2bedee12b45db1f243ac826aee4e80866 100644

--- a/net/dns/dns_protocol.h

+++ b/net/dns/dns_protocol.h

@@ -128,7 +128,6 @@ static const uint16_t kTypeNSEC = 47;

// DNS reply codes (RCODEs).

// https://www.iana.org/assignments/dns-parameters/dns-parameters.xhtml#dns-parameters-6

-static const uint8_t kRcodeMask = 0xf;

static const uint8_t kRcodeNOERROR = 0;

static const uint8_t kRcodeFORMERR = 1;

static const uint8_t kRcodeSERVFAIL = 2;

« no previous file with comments | « no previous file | net/dns/dns_response.cc » ('j') | no next file with comments »