Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2545163002: net: move kRcodeMask into dns_response.cc (Closed)

Created:
4 years ago by tfarina
Modified:
4 years ago
Reviewers:
Julia Tuttle
CC:
chromium-reviews, cbentzel+watch_chromium.org, mmenke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

net: move kRcodeMask into dns_response.cc It is used only there and it is not part of the public protocol. BUG=None TEST=net_unittests R=juliatuttle@chromium.org Committed: https://crrev.com/b0dfc121a4ab3713937d60505f1588374e5d5f2b Cr-Commit-Position: refs/heads/master@{#436194}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M net/dns/dns_protocol.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/dns/dns_response.cc View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
tfarina
4 years ago (2016-12-02 20:13:57 UTC) #3
Julia Tuttle
lgtm
4 years ago (2016-12-04 02:17:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2545163002/1
4 years ago (2016-12-04 13:48:55 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-04 15:22:20 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-04 15:24:40 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b0dfc121a4ab3713937d60505f1588374e5d5f2b
Cr-Commit-Position: refs/heads/master@{#436194}

Powered by Google App Engine
This is Rietveld 408576698