sczs@google.com changed reviewers: + rohitrao@chromium.org
PTAL
https://codereview.chromium.org/2545143003/diff/1/ios/chrome/browser/ui/tabs/... File ios/chrome/browser/ui/tabs/BUILD.gn (right): https://codereview.chromium.org/2545143003/diff/1/ios/chrome/browser/ui/tabs/... ios/chrome/browser/ui/tabs/BUILD.gn:6: sources = [ There are lots of @3x~ipad images in this folder that are not referenced by the gn file. Can you remove them? https://codereview.chromium.org/2545143003/diff/1/ios/chrome/browser/ui/tabs/... ios/chrome/browser/ui/tabs/BUILD.gn:36: "resources/tabstrip_toggle_button_gradient@3x~ipad.png", This image is almost certainly unused by the app, but let's keep it in for now.
Removed, PTAL. https://codereview.chromium.org/2545143003/diff/1/ios/chrome/browser/ui/tabs/... File ios/chrome/browser/ui/tabs/BUILD.gn (right): https://codereview.chromium.org/2545143003/diff/1/ios/chrome/browser/ui/tabs/... ios/chrome/browser/ui/tabs/BUILD.gn:6: sources = [ On 2016/12/02 21:36:34, rohitrao wrote: > There are lots of @3x~ipad images in this folder that are not referenced by the > gn file. Can you remove them? Done. https://codereview.chromium.org/2545143003/diff/1/ios/chrome/browser/ui/tabs/... ios/chrome/browser/ui/tabs/BUILD.gn:36: "resources/tabstrip_toggle_button_gradient@3x~ipad.png", On 2016/12/02 21:36:34, rohitrao wrote: > This image is almost certainly unused by the app, but let's keep it in for now. Acknowledged.
The CQ bit was checked by rohitrao@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480721539180450, "parent_rev": "15023e61ecaad83503ad0ce5e0ea93606ecede64", "commit_rev": "91dc9053e95d9160a03eb6102be92d2cdd749d6c"}
Committed patchset #2 (id:20001)
Description was changed from ========== [ios] Adds tabs, tab_switcher and toolbar resources BUG=666732 ========== to ========== [ios] Adds tabs, tab_switcher and toolbar resources BUG=666732 Committed: https://crrev.com/6108971a795c17c9907e37d521c3ae83a4b0220f Cr-Commit-Position: refs/heads/master@{#436142} ==========
Patchset 2 (id:??) landed as https://crrev.com/6108971a795c17c9907e37d521c3ae83a4b0220f Cr-Commit-Position: refs/heads/master@{#436142}
Chromium Code Reviews
Issue
2545143003:
[ios] Adds tabs, tab_switcher and toolbar resources (Closed)
!["resources/tabstrip_toggle_button_gradient@3x~ipad.png"](mailto:"resources/tabstrip_toggle_button_gradient@3x~ipad.png"){kind=link}