Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Side by Side Diff: chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.h

Issue 2545133002: PlzNavigate: Fix ordering of onBeforeNavigate and onCreatedNavigationTarget. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_API_WEB_NAVIGATION_WEB_NAVIGATION_API_HELPERS_ H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_API_WEB_NAVIGATION_WEB_NAVIGATION_API_HELPERS_ H_
6 #define CHROME_BROWSER_EXTENSIONS_API_WEB_NAVIGATION_WEB_NAVIGATION_API_HELPERS_ H_ 6 #define CHROME_BROWSER_EXTENSIONS_API_WEB_NAVIGATION_WEB_NAVIGATION_API_HELPERS_ H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "extensions/browser/extension_event_histogram_value.h" 10 #include "extensions/browser/extension_event_histogram_value.h"
11 #include "ui/base/page_transition_types.h" 11 #include "ui/base/page_transition_types.h"
12 12
13 namespace content { 13 namespace content {
14 class BrowserContext; 14 class BrowserContext;
15 class NavigationHandle; 15 class NavigationHandle;
16 class RenderFrameHost; 16 class RenderFrameHost;
17 class WebContents; 17 class WebContents;
18 } 18 }
19 19
20 class GURL; 20 class GURL;
21 21
22 namespace extensions { 22 namespace extensions {
23 23
24 struct Event;
25
24 namespace web_navigation_api_helpers { 26 namespace web_navigation_api_helpers {
25 27
26 // Returns the frame ID as it will be passed to the extension: 28 // Returns the frame ID as it will be passed to the extension:
27 // 0 if the navigation happens in the main frame, or the frame routing ID 29 // 0 if the navigation happens in the main frame, or the frame routing ID
28 // otherwise. 30 // otherwise.
29 int GetFrameId(content::RenderFrameHost* frame_host); 31 int GetFrameId(content::RenderFrameHost* frame_host);
30 32
31 // Create and dispatch the various events of the webNavigation API. 33 // Create and dispatch the various events of the webNavigation API.
32 void DispatchOnBeforeNavigate(content::NavigationHandle* navigation_handle); 34 std::unique_ptr<Event> CreateOnBeforeNavigateEvent(
35 content::NavigationHandle* navigation_handle);
33 36
34 void DispatchOnCommitted(events::HistogramValue histogram_value, 37 void DispatchOnCommitted(events::HistogramValue histogram_value,
35 const std::string& event_name, 38 const std::string& event_name,
36 content::NavigationHandle* navigation_handle); 39 content::NavigationHandle* navigation_handle);
37 40
38 void DispatchOnDOMContentLoaded(content::WebContents* web_contents, 41 void DispatchOnDOMContentLoaded(content::WebContents* web_contents,
39 content::RenderFrameHost* frame_host, 42 content::RenderFrameHost* frame_host,
40 const GURL& url); 43 const GURL& url);
41 44
42 void DispatchOnCompleted(content::WebContents* web_contents, 45 void DispatchOnCompleted(content::WebContents* web_contents,
(...skipping 16 matching lines...) Expand all
59 void DispatchOnTabReplaced( 62 void DispatchOnTabReplaced(
60 content::WebContents* old_web_contents, 63 content::WebContents* old_web_contents,
61 content::BrowserContext* browser_context, 64 content::BrowserContext* browser_context,
62 content::WebContents* new_web_contents); 65 content::WebContents* new_web_contents);
63 66
64 } // namespace web_navigation_api_helpers 67 } // namespace web_navigation_api_helpers
65 68
66 } // namespace extensions 69 } // namespace extensions
67 70
68 #endif // CHROME_BROWSER_EXTENSIONS_API_WEB_NAVIGATION_WEB_NAVIGATION_API_HELPE RS_H_ 71 #endif // CHROME_BROWSER_EXTENSIONS_API_WEB_NAVIGATION_WEB_NAVIGATION_API_HELPE RS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698