Issue 25451002: Temporarily add OVERRIDE to width()/height() in TestWebGraphicsContext3D

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25451002: Temporarily add OVERRIDE to width()/height() in TestWebGraphicsContext3D (Closed)

Created:
7 years, 2 months ago by piman

Modified:
7 years, 2 months ago

Reviewers:
jamesr

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Temporarily add OVERRIDE to width()/height() in TestWebGraphicsContext3D This is needed to land https://codereview.chromium.org/25450002 in blink. After width()/height() are removed from WGC3D, TestWebGraphicsContext3D::width() overrides FakeWebGraphicsContext3D::width() which is in chromium land, and the clang plugin complains if it's not OVERRIDE then. BUG=181120 R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226139

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	cc/debug/test_web_graphics_context_3d.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

jamesr

lgtm This is annoying - the clang check is based on namespace. Maybe we could ...

7 years, 2 months ago (2013-10-01 04:34:44 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/25451002/1

7 years, 2 months ago (2013-10-01 04:54:49 UTC) #3

piman

7 years, 2 months ago (2013-10-01 04:57:08 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r226139 (presubmit successful).