Subtract scan/parse time from unlinked summary perf statistic.

Subtract scan/parse time from unlinked summary perf statistic.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/fe1a6847899a15c221e59522b1c26127a8b656dd

[Paul Berry, 2016-12-03 02:47:59]

paulberry@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2016-12-04 05:01:48]

lgtm

https://codereview.chromium.org/2545073004/diff/1/pkg/front_end/tool/perf.dart
File pkg/front_end/tool/perf.dart (right):

https://codereview.chromium.org/2545073004/diff/1/pkg/front_end/tool/perf.dar...
pkg/front_end/tool/perf.dart:205: report('unlinked summarize',
unlinkedSummarizeTimer.elapsedMicroseconds);
I wonder if we should continue to include the parse time here (or add one more
result with parse + summarize). In particular, I'm thinking we might want to use
the parse+summary time when we run this as a benchmark, since it will make it
easier to do a comparison with alternatives that avoid the full cost of parsing
(e.g.  if we use a technique that generates summaries using selective parsing
like the experiment from this week). 

We can always compute the parse+summarize totals in the benchmark runners
though, it's just easier to have it here already.

[Paul Berry, 2016-12-05 16:01:01]

https://codereview.chromium.org/2545073004/diff/1/pkg/front_end/tool/perf.dart
File pkg/front_end/tool/perf.dart (right):

https://codereview.chromium.org/2545073004/diff/1/pkg/front_end/tool/perf.dar...
pkg/front_end/tool/perf.dart:205: report('unlinked summarize',
unlinkedSummarizeTimer.elapsedMicroseconds);
On 2016/12/04 05:01:48, Siggi Cherem (dart-lang) wrote:
> I wonder if we should continue to include the parse time here (or add one more
> result with parse + summarize). In particular, I'm thinking we might want to
use
> the parse+summary time when we run this as a benchmark, since it will make it
> easier to do a comparison with alternatives that avoid the full cost of
parsing
> (e.g.  if we use a technique that generates summaries using selective parsing
> like the experiment from this week). 
> 
> We can always compute the parse+summarize totals in the benchmark runners
> though, it's just easier to have it here already.

Good idea.  PTAL.

[Siggi Cherem (dart-lang), 2016-12-05 19:10:57]

lgtm

[Siggi Cherem (dart-lang), 2016-12-05 19:11:07]

thanks! :)

[Paul Berry, 2016-12-05 19:50:28]

Description was changed from

==========
Subtract scan/parse time from unlinked summary perf statistic.
==========

to

==========
Subtract scan/parse time from unlinked summary perf statistic.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/fe1a6847899a15c221e59522b1c26127a8b656dd
==========

[Paul Berry, 2016-12-05 19:50:29]

Committed patchset #4 (id:60001) manually as
fe1a6847899a15c221e59522b1c26127a8b656dd (presubmit successful).