Part 3.6: Is policy list subsumed under subsuming policy?

Part 3.6: Is policy list subsumed under subsuming policy?

This is part of an experimental feature Embedding-CSP.

In this CL we check subsumption for nonces and hashes.

BUG=647588
Committed: https://crrev.com/bcb1aa7c25d64df51841df3dbb47eb5d3c68b58a
Cr-Commit-Position: refs/heads/master@{#437224}

[amalika, 2016-12-02 14:58:49]

Patchset #2 (id:20001) has been deleted

[amalika, 2016-12-02 15:00:19]

Patchset #2 (id:40001) has been deleted

[amalika, 2016-12-02 15:01:16]

amalika@google.com changed reviewers:
+ jochen@chromium.org, mkwst@chromium.org

[amalika, 2016-12-02 15:01:17]

Adding subsumption for nonces and hashes.
For now we just check exact matches for the former.

[amalika, 2016-12-06 15:34:22]

Patchset #3 (id:80001) has been deleted

[Mike West, 2016-12-07 13:32:47]

LGTM % comments.

https://codereview.chromium.org/2545063002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/csp/SourceListDirectiveTest.cpp
(right):

https://codereview.chromium.org/2545063002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/csp/SourceListDirectiveTest.cpp:857:
"http://example.com 'nonce-abc' 'nonce-xyz' 'nonce' 'unsafe-inline'",
Is `'nonce'` the template bit we talked about? If not, let's leave it out for
the moment until we define it. :)

https://codereview.chromium.org/2545063002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/csp/SourceListDirectiveTest.cpp:862: String
expectedReversed;
You don't define this in any of the items below. Did you intent to do so?

https://codereview.chromium.org/2545063002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/csp/SourceListDirectiveTest.cpp:864:
{"http:", ""},
Might as well add tests for `'unsafe-inline'`, `http://example.com`,
`https://example.com`, and `example.com`.

https://codereview.chromium.org/2545063002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/frame/csp/SourceListDirective.cpp (right):

https://codereview.chromium.org/2545063002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/frame/csp/SourceListDirective.cpp:700: }
Since these two are ~exactly the same code, you could use a template if you
like. Less code, and you get to use excitingly-angled brackets! Up to you.

https://codereview.chromium.org/2545063002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/frame/csp/SourceListDirectiveTest.cpp
(right):

https://codereview.chromium.org/2545063002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/frame/csp/SourceListDirectiveTest.cpp:862: String
expectedReversed;
You're not using this. Did you intend to?

https://codereview.chromium.org/2545063002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/frame/csp/SourceListDirectiveTest.cpp:898: String
expectedReversed;
Ditto. I'm a little surprised this compiled...

[amalika, 2016-12-07 15:11:51]

https://codereview.chromium.org/2545063002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/csp/SourceListDirectiveTest.cpp
(right):

https://codereview.chromium.org/2545063002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/csp/SourceListDirectiveTest.cpp:857:
"http://example.com 'nonce-abc' 'nonce-xyz' 'nonce' 'unsafe-inline'",
On 2016/12/07 at 13:32:46, Mike West (slow) wrote:
> Is `'nonce'` the template bit we talked about? If not, let's leave it out for
the moment until we define it. :)

it was intended to be a non-valid nonce. I changed it to 'nonce-'

https://codereview.chromium.org/2545063002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/csp/SourceListDirectiveTest.cpp:862: String
expectedReversed;
On 2016/12/07 at 13:32:46, Mike West (slow) wrote:
> You don't define this in any of the items below. Did you intent to do so?

Hm yes, it is weird it compiles like this.

https://codereview.chromium.org/2545063002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/csp/SourceListDirectiveTest.cpp:864:
{"http:", ""},
On 2016/12/07 at 13:32:46, Mike West (slow) wrote:
> Might as well add tests for `'unsafe-inline'`, `http://example.com`,
`https://example.com`, and `example.com`.

Added!

https://codereview.chromium.org/2545063002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/frame/csp/SourceListDirective.cpp (right):

https://codereview.chromium.org/2545063002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/frame/csp/SourceListDirective.cpp:700: }
On 2016/12/07 at 13:32:46, Mike West (slow) wrote:
> Since these two are ~exactly the same code, you could use a template if you
like. Less code, and you get to use excitingly-angled brackets! Up to you.

Discussed! The other way around did not work either...

[amalika, 2016-12-07 15:12:23]

The CQ bit was checked by amalika@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 15:12:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 16:34:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 16:34:50]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[amalika, 2016-12-08 09:23:33]

The CQ bit was checked by amalika@google.com

[amalika, 2016-12-08 09:23:33]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/2545063002/#ps140001
(title: "Rebasing")

[commit-bot: I haz the power, 2016-12-08 09:23:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 10:08:53]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1481189013647120,
"parent_rev": "1baf68c50d441191d85aef4150353187da19843e", "commit_rev":
"8f88023a9b021d53759d1a51f5f62dd0897c2f00"}

[commit-bot: I haz the power, 2016-12-08 10:09:20]

Committed patchset #5 (id:140001)

[commit-bot: I haz the power, 2016-12-08 10:11:09]

Description was changed from

==========
Part 3.6: Is policy list subsumed under subsuming policy?

This is part of an experimental feature Embedding-CSP.

In this CL we check subsumption for nonces and hashes.

BUG=647588
==========

to

==========
Part 3.6: Is policy list subsumed under subsuming policy?

This is part of an experimental feature Embedding-CSP.

In this CL we check subsumption for nonces and hashes.

BUG=647588

Committed: https://crrev.com/bcb1aa7c25d64df51841df3dbb47eb5d3c68b58a
Cr-Commit-Position: refs/heads/master@{#437224}
==========

[commit-bot: I haz the power, 2016-12-08 10:11:10]

Patchset 5 (id:??) landed as
https://crrev.com/bcb1aa7c25d64df51841df3dbb47eb5d3c68b58a
Cr-Commit-Position: refs/heads/master@{#437224}