Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 254503003: Comment out assertion in CSSAnimations.cpp (Closed)

Created:
6 years, 8 months ago by James Cook
Modified:
6 years, 8 months ago
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers, ojan, Ian Vollick, aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Comment out assertion in CSSAnimations.cpp This is causing Chrome OS test failures in debug browser_tests for SimpleWebViewDialogTest.Interstitial. The tests pass without this assertion. Commenting it out while we investigate the underlying issue. BUG=365507 TEST=browser_tests SimpleWebViewDialogTest.Interstitial Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172439

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/core/animation/css/CSSAnimations.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
James Cook
abarth, can you take a look at this, or recommend another reviewer? CQ it if ...
6 years, 8 months ago (2014-04-24 00:54:11 UTC) #1
dstockwell
lgtm
6 years, 8 months ago (2014-04-24 00:57:03 UTC) #2
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 8 months ago (2014-04-24 00:58:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/254503003/1
6 years, 8 months ago (2014-04-24 00:59:22 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-24 02:57:37 UTC) #5
Message was sent while issue was closed.
Change committed as 172439

Powered by Google App Engine
This is Rietveld 408576698