Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2545023002:
Clean up around FrameFetchContext (Closed)
|
Created:
4 years ago by tyoshino (SeeGerritForStatus) Modified:
4 years ago CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, gavinp+loader_chromium.org, Nate Chapin, loading-reviews_chromium.org, rwlbuis, sof, tyoshino+watch_chromium.org, Yoav Weiss Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionClean up around FrameFetchContext
- Split FrameFetchContext::createContextAndFetcher() into two methods
and give more descriptive name to them.
- Add DCHECKs to clarify where instances are expected to be
null/non-null
- Factor out frameOfImportsController() from FrameFetchContext::frame()
to ease understanding where the returned LocalFrame came from and
call frameOfImportsController() directly where it's clear than calling
frame().
R=yhirano@chromium.org,hayato@chromium.org
BUG=671533
Committed: https://crrev.com/092e72e03beccd15b99748e51df91cb47a79dd74
Cr-Commit-Position: refs/heads/master@{#436556}
Patch Set 1 : a #Patch Set 2 : Rebase #
Messages
Total messages: 31 (21 generated)
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Description was changed from ========== Split FrameFetchContext::createContextAndFetcher() BUG=none ========== to ========== Clean up around FrameFetchContext - Split FrameFetchContext::createContextAndFetcher() into two methods and give more descriptive name to them. - Add DCHECKs to clarify where instances are expected to be null/non-null - Factor out frameOfImportsController() from FrameFetchContext::frame() to ease understanding where the returned LocalFrame came from and call frameOfImportsController() directly where it's clear than calling frame(). BUG=none ==========
Description was changed from ========== Clean up around FrameFetchContext - Split FrameFetchContext::createContextAndFetcher() into two methods and give more descriptive name to them. - Add DCHECKs to clarify where instances are expected to be null/non-null - Factor out frameOfImportsController() from FrameFetchContext::frame() to ease understanding where the returned LocalFrame came from and call frameOfImportsController() directly where it's clear than calling frame(). BUG=none ========== to ========== Clean up around FrameFetchContext - Split FrameFetchContext::createContextAndFetcher() into two methods and give more descriptive name to them. - Add DCHECKs to clarify where instances are expected to be null/non-null - Factor out frameOfImportsController() from FrameFetchContext::frame() to ease understanding where the returned LocalFrame came from and call frameOfImportsController() directly where it's clear than calling frame(). BUG=none ==========
tyoshino@chromium.org changed reviewers: + yhirano@chromium.org
lgtm
tyoshino@chromium.org changed reviewers: + hayato@chromium.org
+hayato Hayato-san, please take a look at Document.cpp
The CQ bit was checked by tyoshino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
Description was changed from ========== Clean up around FrameFetchContext - Split FrameFetchContext::createContextAndFetcher() into two methods and give more descriptive name to them. - Add DCHECKs to clarify where instances are expected to be null/non-null - Factor out frameOfImportsController() from FrameFetchContext::frame() to ease understanding where the returned LocalFrame came from and call frameOfImportsController() directly where it's clear than calling frame(). BUG=none ========== to ========== Clean up around FrameFetchContext - Split FrameFetchContext::createContextAndFetcher() into two methods and give more descriptive name to them. - Add DCHECKs to clarify where instances are expected to be null/non-null - Factor out frameOfImportsController() from FrameFetchContext::frame() to ease understanding where the returned LocalFrame came from and call frameOfImportsController() directly where it's clear than calling frame(). R=yhirano@chromium.org,hayato@chromium.org BUG=none ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by tyoshino@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yhirano@chromium.org Link to the patchset: https://codereview.chromium.org/2545023002/#ps60001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by tyoshino@chromium.org
The CQ bit was unchecked by tyoshino@chromium.org
Description was changed from ========== Clean up around FrameFetchContext - Split FrameFetchContext::createContextAndFetcher() into two methods and give more descriptive name to them. - Add DCHECKs to clarify where instances are expected to be null/non-null - Factor out frameOfImportsController() from FrameFetchContext::frame() to ease understanding where the returned LocalFrame came from and call frameOfImportsController() directly where it's clear than calling frame(). R=yhirano@chromium.org,hayato@chromium.org BUG=none ========== to ========== Clean up around FrameFetchContext - Split FrameFetchContext::createContextAndFetcher() into two methods and give more descriptive name to them. - Add DCHECKs to clarify where instances are expected to be null/non-null - Factor out frameOfImportsController() from FrameFetchContext::frame() to ease understanding where the returned LocalFrame came from and call frameOfImportsController() directly where it's clear than calling frame(). R=yhirano@chromium.org,hayato@chromium.org BUG=671533 ==========
Created tracking bug: http://crbug.com/671533
The CQ bit was checked by tyoshino@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481014156035740,
"parent_rev": "4d9a3edcf60901d67ef113fc08a5e2ecf1dfde1e", "commit_rev":
"db3cf6f6b70c9116f874f652aa1b3a9413f3d048"}
Message was sent while issue was closed.
Description was changed from ========== Clean up around FrameFetchContext - Split FrameFetchContext::createContextAndFetcher() into two methods and give more descriptive name to them. - Add DCHECKs to clarify where instances are expected to be null/non-null - Factor out frameOfImportsController() from FrameFetchContext::frame() to ease understanding where the returned LocalFrame came from and call frameOfImportsController() directly where it's clear than calling frame(). R=yhirano@chromium.org,hayato@chromium.org BUG=671533 ========== to ========== Clean up around FrameFetchContext - Split FrameFetchContext::createContextAndFetcher() into two methods and give more descriptive name to them. - Add DCHECKs to clarify where instances are expected to be null/non-null - Factor out frameOfImportsController() from FrameFetchContext::frame() to ease understanding where the returned LocalFrame came from and call frameOfImportsController() directly where it's clear than calling frame(). R=yhirano@chromium.org,hayato@chromium.org BUG=671533 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Clean up around FrameFetchContext - Split FrameFetchContext::createContextAndFetcher() into two methods and give more descriptive name to them. - Add DCHECKs to clarify where instances are expected to be null/non-null - Factor out frameOfImportsController() from FrameFetchContext::frame() to ease understanding where the returned LocalFrame came from and call frameOfImportsController() directly where it's clear than calling frame(). R=yhirano@chromium.org,hayato@chromium.org BUG=671533 ========== to ========== Clean up around FrameFetchContext - Split FrameFetchContext::createContextAndFetcher() into two methods and give more descriptive name to them. - Add DCHECKs to clarify where instances are expected to be null/non-null - Factor out frameOfImportsController() from FrameFetchContext::frame() to ease understanding where the returned LocalFrame came from and call frameOfImportsController() directly where it's clear than calling frame(). R=yhirano@chromium.org,hayato@chromium.org BUG=671533 Committed: https://crrev.com/092e72e03beccd15b99748e51df91cb47a79dd74 Cr-Commit-Position: refs/heads/master@{#436556} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/092e72e03beccd15b99748e51df91cb47a79dd74 Cr-Commit-Position: refs/heads/master@{#436556} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
