Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: content/child/child_thread_impl.h

Issue 2544953002: content: Some code cleanup related to shared memory allocation. (Closed)
Patch Set: tot merge Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/child_shared_bitmap_manager.cc ('k') | content/child/child_thread_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/child_thread_impl.h
diff --git a/content/child/child_thread_impl.h b/content/child/child_thread_impl.h
index 592a02341a26cbbcb7a9f76bd40aba908a29472c..aabe0f9c417123b7ff9aa09bf1867d80719edde4 100644
--- a/content/child/child_thread_impl.h
+++ b/content/child/child_thread_impl.h
@@ -109,20 +109,9 @@ class CONTENT_EXPORT ChildThreadImpl
mojom::RouteProvider* GetRemoteRouteProvider();
- // Allocates a block of shared memory of the given size. Returns NULL on
- // failure.
- // Note: On posix, this requires a sync IPC to the browser process,
- // but on windows the child process directly allocates the block.
- std::unique_ptr<base::SharedMemory> AllocateSharedMemory(size_t buf_size);
-
- // A static variant that can be called on background threads provided
- // the |sender| passed in is safe to use on background threads.
- // |out_of_memory| is an output variable populated on failure which tells the
- // caller whether the failure was caused by an out of memory error.
+ // A static variant that can be called on background threads.
nasko 2016/12/08 18:40:10 A static variant of what? The non-static method is
sadrul 2016/12/08 19:50:59 Done.
static std::unique_ptr<base::SharedMemory> AllocateSharedMemory(
- size_t buf_size,
- IPC::Sender* sender,
- bool* out_of_memory);
+ size_t buf_size);
#if defined(OS_LINUX)
void SetThreadPriority(base::PlatformThreadId id,
« no previous file with comments | « content/child/child_shared_bitmap_manager.cc ('k') | content/child/child_thread_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698