Handling ElaboratedType and InjectedClassNameType in blink_qual_type_matcher.

Handling ElaboratedType and InjectedClassNameType in blink_qual_type_matcher.

ElaboratedType wasn't handled, because of a bug in hasDeclaration
matcher.  We had a workaround in definition of
blink_qual_type_base_matcher, but this didn't fully work (because I
forgot to use this in pointsTo and references).

At any rate, the right way forward is to use hasUnqualifiedDesugaredType
matcher, which has landed in https://reviews.llvm.org/D27207 (aka
rL288366) in upstream clang.  This is the right way, because
1) hasUnqualifiedDesugaredType will desugar not only through
   ElaboratedType, but also through TypedefAliasType (which is a good
   thing, because we don't want to rename in case of
   variableOfTypeAliasDefinedInBlinkButPointingToNonBlinkType->dontRename()).
2) Another pending clang change (https://reviews.llvm.org/D27104) will
   remove desugaring from hasDeclaration(type/qualType) - this CL
   insulates us from this change.

The changes described above fix https://crbug.com/670434.

It turns out that after the fix we also need to explicitly handle
hopping over InjectedClassNameType, which luckily was caught by one of
already existing tests in function-templates-original.cc (the type of
|this| in constructor of Checked is an InjectedClassNameType).

BUG=670434
Committed: https://crrev.com/2f5f4c91d9b4d3087533b7e2068d5e81c989c933
Cr-Commit-Position: refs/heads/master@{#436004}

[Łukasz Anforowicz, 2016-12-01 22:42:18]

Description was changed from

==========
Handling ElaboratedType and InjectedClassNameType in blink_qual_type_matcher.

ElaboratedType wasn't handled, because of a bug in hasDeclaration
matcher.  The new way forward is to use hasUnqualifiedDesugaredType
matcher, which has landed in https://reviews.llvm.org/D27207 (aka
rL288366) in upstream clang.  hasUnqualifiedDesugaredType will desugar
not only through ElaboratedType, but also through TypedefAliasType
(which is a good thing, because we don't want to rename in case of
varialbeOftypeAliasDefinedInBlinkButPointingToNonBlinkType->dontRename()).
Handling of ElaboratedType fixes https://crbug.com/670434.

It turns out that after the fix we also need to explicitly handle
hopping over InjectedClassNameType, which luckily was caught by one of
already existing tests in function-templates-original.cc (the type of
|this| in constructor of Checked is an InjectedClassNameType).

BUG=670434
==========

to

==========
Handling ElaboratedType and InjectedClassNameType in blink_qual_type_matcher.

ElaboratedType wasn't handled, because of a bug in hasDeclaration
matcher.  We had a workaround in definition of
blink_qual_type_base_matcher, but this didn't fully work (because I
forgot to use this in pointsTo and references).

At any rate, the right way forward is to use hasUnqualifiedDesugaredType
matcher, which has landed in https://reviews.llvm.org/D27207 (aka
rL288366) in upstream clang.  This is the right way, because
1) hasUnqualifiedDesugaredType will desugar not only through
   ElaboratedType, but also through TypedefAliasType (which is a good
   thing, because we don't want to rename in case of
   varialbeOftypeAliasDefinedInBlinkButPointingToNonBlinkType->dontRename()).
2) Another pending clang change (https://reviews.llvm.org/D27104) will
   remove desugaring from hasDeclaration(type/qualType) - this CL
   insulates us from this change.

The changes described above fix https://crbug.com/670434.


It turns out that after the fix we also need to explicitly handle
hopping over InjectedClassNameType, which luckily was caught by one of
already existing tests in function-templates-original.cc (the type of
|this| in constructor of Checked is an InjectedClassNameType).


BUG=670434
==========

[Łukasz Anforowicz, 2016-12-01 22:43:43]

lukasza@chromium.org changed reviewers:
+ dcheng@chromium.org

[Łukasz Anforowicz, 2016-12-01 22:43:44]

Daniel, can you PTAL?

[Łukasz Anforowicz, 2016-12-01 22:46:23]

Description was changed from

==========
Handling ElaboratedType and InjectedClassNameType in blink_qual_type_matcher.

ElaboratedType wasn't handled, because of a bug in hasDeclaration
matcher.  We had a workaround in definition of
blink_qual_type_base_matcher, but this didn't fully work (because I
forgot to use this in pointsTo and references).

At any rate, the right way forward is to use hasUnqualifiedDesugaredType
matcher, which has landed in https://reviews.llvm.org/D27207 (aka
rL288366) in upstream clang.  This is the right way, because
1) hasUnqualifiedDesugaredType will desugar not only through
   ElaboratedType, but also through TypedefAliasType (which is a good
   thing, because we don't want to rename in case of
   varialbeOftypeAliasDefinedInBlinkButPointingToNonBlinkType->dontRename()).
2) Another pending clang change (https://reviews.llvm.org/D27104) will
   remove desugaring from hasDeclaration(type/qualType) - this CL
   insulates us from this change.

The changes described above fix https://crbug.com/670434.


It turns out that after the fix we also need to explicitly handle
hopping over InjectedClassNameType, which luckily was caught by one of
already existing tests in function-templates-original.cc (the type of
|this| in constructor of Checked is an InjectedClassNameType).


BUG=670434
==========

to

==========
Handling ElaboratedType and InjectedClassNameType in blink_qual_type_matcher.

ElaboratedType wasn't handled, because of a bug in hasDeclaration
matcher.  We had a workaround in definition of
blink_qual_type_base_matcher, but this didn't fully work (because I
forgot to use this in pointsTo and references).

At any rate, the right way forward is to use hasUnqualifiedDesugaredType
matcher, which has landed in https://reviews.llvm.org/D27207 (aka
rL288366) in upstream clang.  This is the right way, because
1) hasUnqualifiedDesugaredType will desugar not only through
   ElaboratedType, but also through TypedefAliasType (which is a good
   thing, because we don't want to rename in case of
   variableOfTypeAliasDefinedInBlinkButPointingToNonBlinkType->dontRename()).
2) Another pending clang change (https://reviews.llvm.org/D27104) will
   remove desugaring from hasDeclaration(type/qualType) - this CL
   insulates us from this change.

The changes described above fix https://crbug.com/670434.


It turns out that after the fix we also need to explicitly handle
hopping over InjectedClassNameType, which luckily was caught by one of
already existing tests in function-templates-original.cc (the type of
|this| in constructor of Checked is an InjectedClassNameType).


BUG=670434
==========

[dcheng, 2016-12-02 18:34:52]

lgtm

[Łukasz Anforowicz, 2016-12-02 19:51:12]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2016-12-02 19:52:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 20:05:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480708272053300,
"parent_rev": "5e16e695dc82665f475a1287c714ea0850967c4d", "commit_rev":
"f3a8b8fa8bf2d6d3c174e220e45741b3d6b30561"}

[commit-bot: I haz the power, 2016-12-02 20:05:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-02 20:09:39]

Description was changed from

==========
Handling ElaboratedType and InjectedClassNameType in blink_qual_type_matcher.

ElaboratedType wasn't handled, because of a bug in hasDeclaration
matcher.  We had a workaround in definition of
blink_qual_type_base_matcher, but this didn't fully work (because I
forgot to use this in pointsTo and references).

At any rate, the right way forward is to use hasUnqualifiedDesugaredType
matcher, which has landed in https://reviews.llvm.org/D27207 (aka
rL288366) in upstream clang.  This is the right way, because
1) hasUnqualifiedDesugaredType will desugar not only through
   ElaboratedType, but also through TypedefAliasType (which is a good
   thing, because we don't want to rename in case of
   variableOfTypeAliasDefinedInBlinkButPointingToNonBlinkType->dontRename()).
2) Another pending clang change (https://reviews.llvm.org/D27104) will
   remove desugaring from hasDeclaration(type/qualType) - this CL
   insulates us from this change.

The changes described above fix https://crbug.com/670434.


It turns out that after the fix we also need to explicitly handle
hopping over InjectedClassNameType, which luckily was caught by one of
already existing tests in function-templates-original.cc (the type of
|this| in constructor of Checked is an InjectedClassNameType).


BUG=670434
==========

to

==========
Handling ElaboratedType and InjectedClassNameType in blink_qual_type_matcher.

ElaboratedType wasn't handled, because of a bug in hasDeclaration
matcher.  We had a workaround in definition of
blink_qual_type_base_matcher, but this didn't fully work (because I
forgot to use this in pointsTo and references).

At any rate, the right way forward is to use hasUnqualifiedDesugaredType
matcher, which has landed in https://reviews.llvm.org/D27207 (aka
rL288366) in upstream clang.  This is the right way, because
1) hasUnqualifiedDesugaredType will desugar not only through
   ElaboratedType, but also through TypedefAliasType (which is a good
   thing, because we don't want to rename in case of
   variableOfTypeAliasDefinedInBlinkButPointingToNonBlinkType->dontRename()).
2) Another pending clang change (https://reviews.llvm.org/D27104) will
   remove desugaring from hasDeclaration(type/qualType) - this CL
   insulates us from this change.

The changes described above fix https://crbug.com/670434.

It turns out that after the fix we also need to explicitly handle
hopping over InjectedClassNameType, which luckily was caught by one of
already existing tests in function-templates-original.cc (the type of
|this| in constructor of Checked is an InjectedClassNameType).

BUG=670434

Committed: https://crrev.com/2f5f4c91d9b4d3087533b7e2068d5e81c989c933
Cr-Commit-Position: refs/heads/master@{#436004}
==========

[commit-bot: I haz the power, 2016-12-02 20:09:39]

Patchset 2 (id:??) landed as
https://crrev.com/2f5f4c91d9b4d3087533b7e2068d5e81c989c933
Cr-Commit-Position: refs/heads/master@{#436004}