Remove RefPtr<ScriptState> from PromiseRejectionEvent

Remove RefPtr<ScriptState> from PromiseRejectionEvent

RefPtr<ScriptState> stored in a DOM object has a risk of leaking ScriptStates
to another world (see the bug for more details). This CL replaces
PromiseRejectionEvent::m_scriptState with PromiseRejectionEvent::m_world.
This matches what we're doing for ErrorEvent.

BUG=669812
Committed: https://crrev.com/05528ffaebde3c6b3534001096dcbdcc4814a931
Cr-Commit-Position: refs/heads/master@{#435882}

[haraken, 2016-12-02 05:12:25]

haraken@chromium.org changed reviewers:
+ yukishiino@chromium.org

[haraken, 2016-12-02 05:12:25]

PTAL

[Yuki, 2016-12-02 05:59:30]

https://codereview.chromium.org/2544883005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp (right):

https://codereview.chromium.org/2544883005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp:50: if
(m_reason.isEmpty() || canBeDispatchedInWorld(scriptState->world()))
Did you forget ! (negate operator)?

[haraken, 2016-12-02 06:02:35]

On 2016/12/02 05:59:30, Yuki wrote:
>
https://codereview.chromium.org/2544883005/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp (right):
> 
>
https://codereview.chromium.org/2544883005/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp:50: if
> (m_reason.isEmpty() || canBeDispatchedInWorld(scriptState->world()))
> Did you forget ! (negate operator)?

Thanks, fixed.

[Yuki, 2016-12-02 06:15:39]

lgtm

https://codereview.chromium.org/2544883005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp (right):

https://codereview.chromium.org/2544883005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp:42: if
(canBeDispatchedInWorld(scriptState->world()))
You need ! here, too.

[haraken, 2016-12-02 06:15:59]

On 2016/12/02 06:15:39, Yuki wrote:
> lgtm
> 
>
https://codereview.chromium.org/2544883005/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp (right):
> 
>
https://codereview.chromium.org/2544883005/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/events/PromiseRejectionEvent.cpp:42: if
> (canBeDispatchedInWorld(scriptState->world()))
> You need ! here, too.

Fixed.

[haraken, 2016-12-02 06:16:05]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-12-02 06:16:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 08:19:03]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480659365347790,
"parent_rev": "8934c75c1ddca0881a693c082512199d76dc4437", "commit_rev":
"b9c47c58895c47721bf5a334026560a4dd493645"}

[commit-bot: I haz the power, 2016-12-02 08:19:28]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-02 08:22:49]

Description was changed from

==========
Remove RefPtr<ScriptState> from PromiseRejectionEvent

RefPtr<ScriptState> stored in a DOM object has a risk of leaking ScriptStates
to another world (see the bug for more details). This CL replaces
PromiseRejectionEvent::m_scriptState with PromiseRejectionEvent::m_world.
This matches what we're doing for ErrorEvent.

BUG=669812
==========

to

==========
Remove RefPtr<ScriptState> from PromiseRejectionEvent

RefPtr<ScriptState> stored in a DOM object has a risk of leaking ScriptStates
to another world (see the bug for more details). This CL replaces
PromiseRejectionEvent::m_scriptState with PromiseRejectionEvent::m_world.
This matches what we're doing for ErrorEvent.

BUG=669812

Committed: https://crrev.com/05528ffaebde3c6b3534001096dcbdcc4814a931
Cr-Commit-Position: refs/heads/master@{#435882}
==========

[commit-bot: I haz the power, 2016-12-02 08:22:50]

Patchset 3 (id:??) landed as
https://crrev.com/05528ffaebde3c6b3534001096dcbdcc4814a931
Cr-Commit-Position: refs/heads/master@{#435882}