Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2544883004: Omnibox Metrics - Add Missing Enum to histograms.xml (Closed)

Created:
4 years ago by Mark P
Modified:
4 years ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org, Tom Anderson
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Omnibox Metrics - Add Missing Enum to histograms.xml These were added to the code in https://codereview.chromium.org/1855423003 BUG= Committed: https://crrev.com/167080b5960ea0a5d8999e180aa889c80334f29e Cr-Commit-Position: refs/heads/master@{#436126}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Mark P
Ilya, can you please review this? thanks, mark
4 years ago (2016-12-01 23:41:08 UTC) #3
Ilya Sherman
lgtm, thanks
4 years ago (2016-12-02 01:41:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2544883004/1
4 years ago (2016-12-02 22:15:12 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/78886)
4 years ago (2016-12-03 00:12:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2544883004/1
4 years ago (2016-12-03 00:15:22 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-03 01:28:10 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-03 01:31:32 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/167080b5960ea0a5d8999e180aa889c80334f29e
Cr-Commit-Position: refs/heads/master@{#436126}

Powered by Google App Engine
This is Rietveld 408576698