Implement 'topLevelLibraryDeclarations' getter to return all libraries with exported top-level decl…

Implement 'topLevelLibraryDeclarations' getter to return all libraries with exported top-level declarations.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/8524189ca0631db2b5383d6216a87c6d48d23a4c

[Brian Wilkerson, 2016-12-01 22:23:36]

lgtm

[Paul Berry, 2016-12-01 22:28:16]

https://codereview.chromium.org/2544883003/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2544883003/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:308:
Future<List<TopLevelLibraryDeclarations>> get topLevelLibraryDeclarations {
I'm concerned that this API forces the driver to compute a lot more information
than the caller really needs.  As far as I understand, the caller just needs to
know which libraries contain a top level declaration matching a certain string.

Under the current design, the only way to get that information is to compute all
top-level duclarations in all known libraries.  Which I think is fine for now. 
But in the future we might find a way to do this more efficiently.  I'd prefer
to have an API that would allow us to make that improvement without it being a
breaking change.

How about something like this instead:

Future<List<Source>> getTopLevelLibrariesExportingName(String name);

[scheglov, 2016-12-02 17:19:13]

PTAL

https://codereview.chromium.org/2544883003/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2544883003/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:308:
Future<List<TopLevelLibraryDeclarations>> get topLevelLibraryDeclarations {
On 2016/12/01 22:28:15, Paul Berry wrote:
> I'm concerned that this API forces the driver to compute a lot more
information
> than the caller really needs.  As far as I understand, the caller just needs
to
> know which libraries contain a top level declaration matching a certain
string.
> 
> Under the current design, the only way to get that information is to compute
all
> top-level duclarations in all known libraries.  Which I think is fine for now.

> But in the future we might find a way to do this more efficiently.  I'd prefer
> to have an API that would allow us to make that improvement without it being a
> breaking change.
> 
> How about something like this instead:
> 
> Future<List<Source>> getTopLevelLibrariesExportingName(String name);

That's a good idea.
Thank you.

We need to know kinds of declarations, for example to filter out variables where
a type is expected.
So, I went with Future<List<TopLevelDeclarationInSource>>
getTopLevelNameDeclarations(String name).

[Brian Wilkerson, 2016-12-02 17:30:06]

lgtm

[Paul Berry, 2016-12-02 17:56:37]

lgtm

https://codereview.chromium.org/2544883003/diff/20001/pkg/analyzer/lib/src/da...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2544883003/diff/20001/pkg/analyzer/lib/src/da...
pkg/analyzer/lib/src/dart/analysis/driver.dart:1351: * Task that computes
top-level declarations in all known libraries.
Nit: Change to "Task that computes top-level declarations for a certain name in
all known libraries."

[scheglov, 2016-12-02 19:20:38]

Description was changed from

==========
Implement 'topLevelLibraryDeclarations' getter to return all libraries with
exported top-level declarations.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Implement 'topLevelLibraryDeclarations' getter to return all libraries with
exported top-level declarations.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/8524189ca0631db2b5383d6216a87c6d48d23a4c
==========

[scheglov, 2016-12-02 19:20:39]

Committed patchset #2 (id:20001) manually as
8524189ca0631db2b5383d6216a87c6d48d23a4c (presubmit successful).