Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2544873002: [Contextual Search] Destroy ContextualSearchQuickActionControl (Closed)

Created:
4 years ago by Theresa
Modified:
4 years ago
Reviewers:
Donn Denman
CC:
chromium-reviews, mdjones+watch_chromium.org, donnd+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Contextual Search] Destroy ContextualSearchQuickActionControl Destroy ContextualSearchQuickActionControl when ContextualSearchBarControl is destroyed. BUG=670153 Committed: https://crrev.com/1c2a5b3653b7c2c4c904f3aa668f7987ec38a648 Cr-Commit-Position: refs/heads/master@{#435692}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchBarControl.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Theresa
ptal
4 years ago (2016-12-01 19:40:15 UTC) #4
Donn Denman
Nice solution! LGTM, will check the commit to CQ bit.
4 years ago (2016-12-01 19:41:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2544873002/1
4 years ago (2016-12-01 19:42:03 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 20:15:34 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-01 20:19:30 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c2a5b3653b7c2c4c904f3aa668f7987ec38a648
Cr-Commit-Position: refs/heads/master@{#435692}

Powered by Google App Engine
This is Rietveld 408576698