Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Side by Side Diff: runtime/vm/compiler.cc

Issue 254483005: - Rationalize the way we use comments. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/assembler.cc ('k') | runtime/vm/flow_graph_compiler.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/compiler.h" 5 #include "vm/compiler.h"
6 6
7 #include "vm/assembler.h" 7 #include "vm/assembler.h"
8 8
9 #include "vm/ast_printer.h" 9 #include "vm/ast_printer.h"
10 #include "vm/block_scheduler.h" 10 #include "vm/block_scheduler.h"
(...skipping 538 matching lines...) Expand 10 before | Expand all | Expand 10 after
549 ASSERT(optimized || !isolate->cha_used()); 549 ASSERT(optimized || !isolate->cha_used());
550 if (isolate->cha_used()) { 550 if (isolate->cha_used()) {
551 Class::Handle(function.Owner()).RegisterCHACode(code); 551 Class::Handle(function.Owner()).RegisterCHACode(code);
552 isolate->set_cha_used(false); 552 isolate->set_cha_used(false);
553 } 553 }
554 graph_compiler.FinalizePcDescriptors(code); 554 graph_compiler.FinalizePcDescriptors(code);
555 graph_compiler.FinalizeDeoptInfo(code); 555 graph_compiler.FinalizeDeoptInfo(code);
556 graph_compiler.FinalizeStackmaps(code); 556 graph_compiler.FinalizeStackmaps(code);
557 graph_compiler.FinalizeVarDescriptors(code); 557 graph_compiler.FinalizeVarDescriptors(code);
558 graph_compiler.FinalizeExceptionHandlers(code); 558 graph_compiler.FinalizeExceptionHandlers(code);
559 graph_compiler.FinalizeComments(code);
560 graph_compiler.FinalizeStaticCallTargetsTable(code); 559 graph_compiler.FinalizeStaticCallTargetsTable(code);
561 560
562 if (optimized) { 561 if (optimized) {
563 if (osr_id == Isolate::kNoDeoptId) { 562 if (osr_id == Isolate::kNoDeoptId) {
564 CodePatcher::PatchEntry(Code::Handle(function.CurrentCode())); 563 CodePatcher::PatchEntry(Code::Handle(function.CurrentCode()));
565 if (FLAG_trace_compiler) { 564 if (FLAG_trace_compiler) {
566 OS::Print("--> patching entry %#" Px "\n", 565 OS::Print("--> patching entry %#" Px "\n",
567 Code::Handle(function.unoptimized_code()).EntryPoint()); 566 Code::Handle(function.unoptimized_code()).EntryPoint());
568 } 567 }
569 } 568 }
(...skipping 390 matching lines...) Expand 10 before | Expand all | Expand 10 after
960 const Object& result = 959 const Object& result =
961 Object::Handle(isolate->object_store()->sticky_error()); 960 Object::Handle(isolate->object_store()->sticky_error());
962 isolate->object_store()->clear_sticky_error(); 961 isolate->object_store()->clear_sticky_error();
963 return result.raw(); 962 return result.raw();
964 } 963 }
965 UNREACHABLE(); 964 UNREACHABLE();
966 return Object::null(); 965 return Object::null();
967 } 966 }
968 967
969 } // namespace dart 968 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/assembler.cc ('k') | runtime/vm/flow_graph_compiler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698