net/spdy/buffered_spdy_framer_unittest.cc - Issue 2544813002: Remove enum SpdyMajorVersion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/buffered_spdy_framer_unittest.cc

Issue 2544813002: Remove enum SpdyMajorVersion. (Closed)

Patch Set: Revert creating local variables to avoid silly compiler error about int to bool conversion. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/spdy/buffered_spdy_framer_unittest.cc

diff --git a/net/spdy/buffered_spdy_framer_unittest.cc b/net/spdy/buffered_spdy_framer_unittest.cc

index cc373163ec30ebb0f6d628f5a3ca2ffd74343c8d..ba6a67dd942d09e5678efcf524b6aaf9e433b77a 100644

--- a/net/spdy/buffered_spdy_framer_unittest.cc

+++ b/net/spdy/buffered_spdy_framer_unittest.cc

@@ -179,7 +179,7 @@ class TestBufferedSpdyVisitor : public BufferedSpdyFramerVisitorInterface {

class BufferedSpdyFramerTest : public PlatformTest {};

TEST_F(BufferedSpdyFramerTest, OnSetting) {

- SpdyFramer framer(HTTP2);

+ SpdyFramer framer;

SpdySettingsIR settings_ir;

settings_ir.AddSetting(SETTINGS_INITIAL_WINDOW_SIZE, false, false, 2);

settings_ir.AddSetting(SETTINGS_MAX_CONCURRENT_STREAMS, false, false, 3);