Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2544793002: [stubs] Cleanup storing of maps to objects. (Closed)

Created:
4 years ago by Igor Sheludko
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Cleanup storing of maps to objects. 1) CSA::StoreMap() added which triggers map-specific write barrier unlike StoreObjectField() which triggers the full write barrier. 2) CSA::StoreMapNoWriteBarrier(object, map_root_index) added. 3) StoreMapNoWriteBarrier() is used for storing immortal immovable maps since they don't require write barriers even for objects in old space. BUG= Committed: https://crrev.com/d4c3fa8d2418c81e0ba06fb7d8b24cff25a7a55e Cr-Commit-Position: refs/heads/master@{#41435}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -52 lines) Patch
M src/code-stub-assembler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/code-stub-assembler.cc View 15 chunks +37 lines, -33 lines 0 comments Download
M src/code-stubs.cc View 5 chunks +14 lines, -13 lines 0 comments Download
M src/compiler/code-assembler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/code-assembler.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/ic/accessor-assembler.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/ic/keyed-store-generic.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 27 (21 generated)
Igor Sheludko
PTAL
4 years ago (2016-12-01 12:52:44 UTC) #5
Michael Starzinger
LGTM on "interpreter", didn't look at the rest.
4 years ago (2016-12-01 16:40:57 UTC) #19
ulan
lgtm!
4 years ago (2016-12-01 16:48:50 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2544793002/80001
4 years ago (2016-12-01 16:49:29 UTC) #22
commit-bot: I haz the power
Committed patchset #1 (id:80001)
4 years ago (2016-12-01 16:51:20 UTC) #25
commit-bot: I haz the power
4 years ago (2016-12-01 16:51:49 UTC) #27
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d4c3fa8d2418c81e0ba06fb7d8b24cff25a7a55e
Cr-Commit-Position: refs/heads/master@{#41435}

Powered by Google App Engine
This is Rietveld 408576698