Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2544733002: Reland Script blocking resources tracking should be only done by Document::isScriptExecutionReady" (Closed)

Created:
4 years ago by kouhei (in TOK)
Modified:
4 years ago
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, kinuko+watch, loading-reviews+parser_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland Script blocking resources tracking should be only done by Document::isScriptExecutionReady" This reverts commit acbd50fc4a51624a65c53ec760cff2bec03ae943. Chrome extensions may invoke executeScriptsWaitingForResources() on HTMLDocumentParser before initializing background HTML parser thread. This CL relands the patch + null check for m_tokenizer. BUG=669435 Committed: https://crrev.com/3b30f9793a39310391ecea42643798877e113fc4 Cr-Commit-Position: refs/heads/master@{#435874}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -37 lines) Patch
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp View 3 chunks +15 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.h View 3 chunks +1 line, -10 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp View 5 chunks +10 lines, -17 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
kouhei (in TOK)
4 years ago (2016-12-01 02:29:58 UTC) #2
yhirano
lgtm
4 years ago (2016-12-01 07:25:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2544733002/1
4 years ago (2016-12-02 05:06:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 07:11:01 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-02 07:13:31 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3b30f9793a39310391ecea42643798877e113fc4
Cr-Commit-Position: refs/heads/master@{#435874}

Powered by Google App Engine
This is Rietveld 408576698